feat : https://datical.atlassian.net/browse/DAT-12842 #3867

sayaliM0412 · 2023-02-27T14:40:22Z

Impact

release-published.yml will now include deploying liquibase and liquibase-pro xsd to cloud front distribution.

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Description

https://datical.atlassian.net/browse/DAT-12842 : Automating the deployment of XSDs to new beta landing site.

Things to be aware of

Need to make sure that the desired/ current xsd's are indeed getting uploaded to s3 bucket at release-published workflow.

.github/workflows/release-published.yml

github-actions · 2023-02-27T15:02:17Z

Unit Test Results

  5 278 files ±0   5 278 suites ±0 35m 57s ⏱️ +39s
  4 861 tests ±0   4 639 ✔️ ±0   222 💤 ±0 0 ❌ ±0
62 361 runs ±0 56 319 ✔️ ±0 6 042 💤 ±0 0 ❌ ±0

Results for commit 00327b7. ± Comparison against base commit 436e699.

♻️ This comment has been updated with latest results.

jnewton03 · 2023-02-27T15:02:44Z

aside from Jandro's comment I think this looks good. You might be able to use working_directory instead of the Github Path environment variables for cleaner looking code, but that's splitting hairs :)

I think once this is ready to test we'll want to setup a manual trigger and comment out everything else so that we can confirm the process works without having to wait on a release.

filipelautert

No more XSD manual work! wheee

changelog.txt

jnewton03

looks great @sayaliM0412! Can be moved to RFT

sayaliM0412 · 2023-02-27T20:07:04Z

@jnewton03 @suryaaki
the pr has an unsuccessful check : can you overwrite it, as its Not Impacting the code
@Merge-Freeze
mergefreeze — Frozen by Surya Aki

sayaliM0412 · 2023-02-27T20:57:12Z

@jnewton03 @suryaaki the pr has an unsuccessful check : can you overwrite it, as its Not Impacting the code @Merge-Freeze mergefreeze — Frozen by Surya Aki

ok, had a talk with @suryaaki and we will wait until we release 4.19.1. He will remove merge freeze sometime tomorrow or Wednesday

.github/workflows/release-published.yml

nvoxland · 2023-02-27T21:14:01Z

.github/workflows/release-published.yml

+          AWS_DEFAULT_REGION: us-east-1
+        run: |
+          aws s3 sync $GITHUB_WORKSPACE/liquibase-core/src/main/resources/www.liquibase.org/xml/ns/dbchangelog/dbchangelog-${{ env.XSD_VERSION }}.xsd s3://liquibaseorg-origin --only-show-errors


I don't know how the s3 sync command works, but nether seem to have a target directory listed? They go in different spots in the s3 hierarchy, is that being managed somewhere?

I just got access to the SFTP server and it will include the full path in my next commit.

@nvoxland is this comment resolved?

I have added a full path for the xsd's which will grab the xsd from the source in liquibase GitHub repo to the target dir in s3 which are different for liquibase-pro and liquibase.

.github/workflows/release-published.yml

jnewton03 · 2023-03-01T22:18:00Z

@sayaliM0412 this looks good to me.

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.liquibase.ext:liquibase-hibernate5](https://github.com/liquibase/liquibase-hibernate/wiki) ([source](https://github.com/liquibase/liquibase-hibernate)) | build | minor | `4.19.1` -> `4.20.0` | | [org.liquibase:liquibase-maven-plugin](http://www.liquibase.org/liquibase-maven-plugin) ([source](https://github.com/liquibase/liquibase)) | build | minor | `4.19.1` -> `4.20.0` | --- ### Release Notes <details> <summary>liquibase/liquibase</summary> ### [`v4.20.0`](https://github.com/liquibase/liquibase/releases/tag/v4.20.0) [Compare Source](liquibase/liquibase@v4.19.1...v4.20.0) ##### Liquibase v4.20.0 is a patch release #### API Breaking Changes - Remove Liquibase Hub auto-registration prompts and no longer support new Liquibase Hub registrations. Please get in touch with customer support with any questions. (DAT-13419) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3886 - Refactor of commands: diff, diffchangelog, generatechangelog DAT-6606, DAT-6607, DAT-6623, DAT-6613 by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3775 #### Enhancements - Automate deployment of XSDs to new beta landing site by [@sayaliM0412](https://github.com/sayaliM0412) in liquibase/liquibase#3867 - Issue 3584: Add support for relativeToChangelogFile for ChangeLogProperty class/property attribute by [@jasonlyle88](https://github.com/jasonlyle88) in liquibase/liquibase#3595 - Jakartaee CDI for liquibase by [@xazap](https://github.com/xazap) in liquibase/liquibase#3642 - Use variable for maven version by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3895 - More maven version pinning by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3887 - Update db changelog xsd to 4.20 by [@suryaaki2](https://github.com/suryaaki2) in liquibase/liquibase#3918 - \[MRO] Refactor of commands: diff, diffchangelog, generatechangelog DAT-6606, DAT-6607 and DAT-6613 by [@filipelautert](https://github.com/filipelautert) in https://github.com/liquibase/liquibase-pro/pull/824 - \[MRO] Update pro xsd and flow schema to 4.20 by [@suryaaki2](https://github.com/suryaaki2) in https://github.com/liquibase/liquibase-pro/pull/861 #### Security, Driver and other updates - Bump actions/cache from 3.2.5 to 3.2.6 by [@dependabot](https://github.com/dependabot) in liquibase/liquibase#3851 - \[MRO] Bump jsqlparser from 4.5 to 4.6 by [@dependabot](https://github.com/dependabot) in https://github.com/liquibase/liquibase-pro/pull/842 - \[MRO] Bump mockito-core from 3.8.0 to 3.12.4 by [@dependabot](https://github.com/dependabot) in https://github.com/liquibase/liquibase-pro/pull/845 - \[MRO] Bump actions/checkout from 2 to 3 by [@dependabot](https://github.com/dependabot) in https://github.com/liquibase/liquibase-pro/pull/846 - \[MRO] Bump actions/setup-java from 2 to 3 by [@dependabot](https://github.com/dependabot) in https://github.com/liquibase/liquibase-pro/pull/847 - \[MRO] Bump schdck/create-env-json from 1 to 2 by [@dependabot](https://github.com/dependabot) in https://github.com/liquibase/liquibase-pro/pull/848 - \[MRO] Bump maven-compiler-plugin from 3.10.1 to 3.11.0 by [@dependabot](https://github.com/dependabot) in https://github.com/liquibase/liquibase-pro/pull/850 #### Fixes - Safely call snakeyaml methods that have been changed in last versions. by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3904 - Only show structured log license message after value providers are registered (DAT-13362) by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3850 - Pin maven version for sonar scan by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3880 - Fix CheckSum generation issues + improvements by [@MalloD12](https://github.com/MalloD12) in liquibase/liquibase#3616 - Structured logging MdcKey renaming by [@StevenMassaro](https://github.com/StevenMassaro) in liquibase/liquibase#3875 - Revert "Fix CheckSum generation issues + CURRENT_CHECKSUM_ALGORITHM_VERSION updated from 8 to 9." by [@filipelautert](https://github.com/filipelautert) in liquibase/liquibase#3892 - \[MRO] only show structured log license message after value providers are registered (DAT-13362) by [@StevenMassaro](https://github.com/StevenMassaro) in https://github.com/liquibase/liquibase-pro/pull/839 - \[MRO] Pin maven to 3.8.7 by [@wwillard7800](https://github.com/wwillard7800) in https://github.com/liquibase/liquibase-pro/pull/855 - \[MRO] GitHub action maven version pin by [@StevenMassaro](https://github.com/StevenMassaro) in https://github.com/liquibase/liquibase-pro/pull/859 #### New Contributors - [@sayaliM0412](https://github.com/sayaliM0412) made their first contribution in liquibase/liquibase#3867 - [@jasonlyle88](https://github.com/jasonlyle88) made their first contribution in liquibase/liquibase#3595 - [@xazap](https://github.com/xazap) made their first contribution in liquibase/liquibase#3642 **Full Changelog**: liquibase/liquibase@v4.19.1...v4.20.0 ##### Get Certified Learn all the Liquibase fundamentals from free online courses by Liquibase experts and see how to apply them in the real world at https://learn.liquibase.com/. ##### Read the Documentation Please check out and contribute to the continually improving docs, now at https://docs.liquibase.com/. ##### Meet the Community Our community has built a lot. From extensions to integrations, you’ve helped make Liquibase the amazing open source project that it is today. Keep contributing to making it stronger: [Contribute code](https://www.liquibase.org/development/contribute.html) [Make doc updates](https://github.com/Datical/liquibase-docs) [Help by asking and answering questions](https://forum.liquibase.org/) [Set up a chat with the Product team](https://calendly.com/liquibase-outreach/product-feedback) Thanks to everyone who helps make the Liquibase community strong! #### File Descriptions - **Liquibase CLI** -- Includes open source + commercial functionality - **liquibase-x.y.z.tar.gz** -- Archive in tar.gz format - **liquibase-x.y.z.zip** -- Archive in zip format - **liquibase-windows-x64-installer-x.y.z.exe** -- Installer for Windows - **liquibase-macos-installer-x.y.z.dmg** -- Installer for MacOS - **Primary Libraries** - For embedding in other software - **liquibase-core-x.y.z.jar** – Base Liquibase library (open source) - **liquibase-commerical-x.y.z.jar** – Additional commercial functionality - **liquibase-additional-x.y.z.zip** – Contains additional, less commonly used files - Additional libraries such as liquibase-maven-plugin.jar and liquibase-cdi.jar - Javadocs for all the libraries - Source archives for all the open source libraries - ASC/MD5/SHA1 verification hashes for all files </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Sayali Mohadikar added 2 commits February 24, 2023 14:02

DAT-12842 temp changes for liquibaseorg set up

b1b0b62

Merge branch 'master' into DAT-12842

2de02c6

sayaliM0412 requested review from jandroav and jnewton03 February 27, 2023 14:42

jandroav reviewed Feb 27, 2023

View reviewed changes

.github/workflows/release-published.yml Outdated Show resolved Hide resolved

suryaaki2 requested review from jandroav, nvoxland and suryaaki2 February 27, 2023 14:57

Sayali Mohadikar added 2 commits February 27, 2023 07:25

DAT-12842 using env variable for working_directory

ca2d478

DAT-12842 get major.minor release version for xsd run

3099dc5

sayaliM0412 marked this pull request as ready for review February 27, 2023 16:49

sayaliM0412 requested a review from filipelautert as a code owner February 27, 2023 16:49

filipelautert approved these changes Feb 27, 2023

View reviewed changes

jnewton03 reviewed Feb 27, 2023

View reviewed changes

changelog.txt Outdated Show resolved Hide resolved

jnewton03 approved these changes Feb 27, 2023

View reviewed changes

fix: typo

481f59b

nvoxland reviewed Feb 27, 2023

View reviewed changes

fix: add gitub token and xsd path

bb54df0

jandroav reviewed Feb 27, 2023

View reviewed changes

.github/workflows/release-published.yml Outdated Show resolved Hide resolved

fix: using GITHUB_ENV to set env variable

8d9771a

sayaliM0412 marked this pull request as draft February 28, 2023 14:11

sayaliM0412 added 3 commits February 28, 2023 06:11

Merge branch 'master' into DAT-12842

e419807

Merge branch 'master' into DAT-12842

9e49620

Merge branch 'master' into DAT-12842

00327b7

sayaliM0412 marked this pull request as ready for review March 1, 2023 21:39

sayaliM0412 merged commit 293d5f0 into master Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat : https://datical.atlassian.net/browse/DAT-12842 #3867

feat : https://datical.atlassian.net/browse/DAT-12842 #3867

sayaliM0412 commented Feb 27, 2023

github-actions bot commented Feb 27, 2023 •

edited

jnewton03 commented Feb 27, 2023

filipelautert left a comment

jnewton03 left a comment

sayaliM0412 commented Feb 27, 2023 •

edited

sayaliM0412 commented Feb 27, 2023

nvoxland Feb 27, 2023

sayaliM0412 Feb 27, 2023

jnewton03 Mar 1, 2023

sayaliM0412 Mar 1, 2023

jnewton03 commented Mar 1, 2023

feat : https://datical.atlassian.net/browse/DAT-12842 #3867

feat : https://datical.atlassian.net/browse/DAT-12842 #3867

Conversation

sayaliM0412 commented Feb 27, 2023

Impact

Description

Things to be aware of

github-actions bot commented Feb 27, 2023 • edited

Unit Test Results

jnewton03 commented Feb 27, 2023

filipelautert left a comment

Choose a reason for hiding this comment

jnewton03 left a comment

Choose a reason for hiding this comment

sayaliM0412 commented Feb 27, 2023 • edited

sayaliM0412 commented Feb 27, 2023

nvoxland Feb 27, 2023

Choose a reason for hiding this comment

sayaliM0412 Feb 27, 2023

Choose a reason for hiding this comment

jnewton03 Mar 1, 2023

Choose a reason for hiding this comment

sayaliM0412 Mar 1, 2023

Choose a reason for hiding this comment

jnewton03 commented Mar 1, 2023

github-actions bot commented Feb 27, 2023 •

edited

sayaliM0412 commented Feb 27, 2023 •

edited