Plan file for cloud server create #30
Conversation
| // put functions within this package... I'm not sure if a bigger package is | ||
| // more appropos that Client is a member of, or if this is actually fine.. | ||
| // or maybe the "instance" package name just makes it feel wrong... | ||
| // feedback is welcome |
There was a problem hiding this comment.
the original thought here as far as "instance" goes.. is because its "creating" an instance of lwCli, that we bring up for global use in cmd/root.go.
If you want to put command helpers like DerivePrivateParentUniqId in its own package, or commands themselves, like the CloudServerCreate you added to instance, I am fine with that. It might help keep things more organized in the future as more commands migrate to support plans.
If you do that, we should probably just make the new packages accessible under instance.Client. That way they are still easily accessible, via things like ci.Cmds.CloudServerCreate or ci.CmdHelpers.DerivePrivateParentUniqId etc
That all said, I would also like to reiterate, im fine leaving it structured the way you have it here too. We could always break things out into separate files as far as the organizational stuff goes to some degree.
There was a problem hiding this comment.
that's a tough call, but the global variable is what makes it most difficult atm, and I didn't want to create a new one if I could avoid it...
I have an idea but my head hurts too much to fully articulate it so I'll not try right now, and it's not something that would prevent merging now because it doesn't change end functionality
No description provided.