Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validators): host validator enforced with URLs only #61

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

lirantal
Copy link
Owner

@lirantal lirantal commented Feb 4, 2020

Description

Hosts validators were showing regression too incase the URL was an invalid one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Comment in #60 (comment)

@lirantal lirantal added the bug Something isn't working label Feb 4, 2020
@lirantal lirantal self-assigned this Feb 4, 2020
@codecov-io
Copy link

codecov-io commented Feb 4, 2020

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          11       11           
  Lines         183      183           
  Branches       29       29           
=======================================
  Hits          174      174           
  Misses          8        8           
  Partials        1        1
Impacted Files Coverage Δ
...s/lockfile-lint-api/src/validators/ValidateHost.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e741421...d638149. Read the comment docs.

@lirantal lirantal merged commit 036edbf into master Feb 4, 2020
@lirantal lirantal deleted the fix/validators-host-regression branch February 19, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants