Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic LSTM tutorial #55

Merged
merged 5 commits into from
Dec 20, 2014
Merged

Add basic LSTM tutorial #55

merged 5 commits into from
Dec 20, 2014

Conversation

carriepl
Copy link
Contributor

No description provided.


return x, x_mask, labels

def load_data(path="/data/lisatmp3/chokyun/tweets_sa/imdb/aclImdb/imdb.pkl", n_words=100000, valid_portion=0.1):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That path should be changed to point to the location of the downloaded data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. That's a copy-paste artefact

@carriepl
Copy link
Contributor Author

I removed the commented out code. Concerning the other points, I am not certain why things are implemented this way. This is Cho and other' LSTM code that Fred asked me to put in a tutorial. I only removed external dependencies to sklearn and scipy and wrote a tutorial around it. I can pep8-ize it but further clean up/refactoring/documenting would probably be more efficiently carried out by the original authors.

@kyunghyuncho
Copy link
Contributor

@carriepl, it'll be nice if you can pep8-ize it. Optimization/clean-up/refactoring may/should happen later by me or others.

@nouiz
Copy link
Member

nouiz commented Dec 20, 2014

pep8 was fixed.

@nouiz
Copy link
Member

nouiz commented Dec 20, 2014

I merge it now to annonce this example. We can polish it later.

nouiz added a commit that referenced this pull request Dec 20, 2014
@nouiz nouiz merged commit fd1d392 into lisa-lab:master Dec 20, 2014
taneishi pushed a commit to taneishi/DBN_CPI that referenced this pull request Nov 28, 2019
taneishi pushed a commit to taneishi/DBN_CPI that referenced this pull request Feb 13, 2020
Add basic LSTM tutorial

Former-commit-id: 664b4cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants