Supporting for Python 2 and 3 with the same code base

[euphoris]

resolve #948

[goodfeli]

If the tests would fail on the intermediate commits, please squash them before the merge. That way we don't need to use "git bisect --skip" as often.

[euphoris]

@goodfeli Tests failed on 5 commits. Because most of fixes are simple syntactic changes (e.g. from except Excetion, e to except Exception as e), any functional test wasn't failed. Failed tests were only related to pep8 (too long line and docstring). Do I need to squash these commits?

[goodfeli]

No, if it's only test_format.py that fails, it's fine not to squash.

[goodfeli]

I'm fine with merging this, do we need approval from a current CCW member?

[bartvm]

I skimmed through this PR this morning and it looked fine to me. We might need to update the pull request checklist in the future to reflect the changes to using e.g. xrange.

[vdumoulin]

I'm also fine with it being merged.

Vincent Dumoulin, B.Sc. Physique et Informatique
Étudiant au Ph.D.
LISA, Université de Montréal
Bureau: 3336, pavillon André-Aisenstadt
vincent.dumoulin@umontreal.ca

On Fri, Nov 14, 2014 at 4:04 PM, Bart van Merriënboer <
notifications@github.com> wrote:

I skimmed through this PR this morning and it looked fine to me. We might
need to update the pull request checklist in the future to reflect the
changes to using e.g. xrange.

—
Reply to this email directly or view it on GitHub
#1240 (comment).

[vdumoulin]

It probably will mean that all current pull requests will need to be rebased, though.

[goodfeli]

I think it's better to rebase the other pull requests than to rebase this one. This one is huge and very hard to rebase. It is also more vulnerable to needing additional rebases since anything we merge is likely to conflict with it. So I'm going to merge it now to avoid this PR getting stuck in an infinite rebase loop.

[dwf]

Erm, I wish I had seen this earlier. This introduces a dependency on six. Are we okay with this?

I'd prefer just throwing six in packaged_dependencies personally.

[lamblin]

six is packaged with Theano, so I guess we could use that version.