Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing test unit for learning rates #1460

Closed
wants to merge 1 commit into from

Conversation

XavierAudier
Copy link
Contributor

Implementing a test for commit #1456

@lamblin
Copy link
Member

lamblin commented Mar 27, 2015

A unit test should check things automatically (and raise an Exception if there is a problem), not simply print things for manual inspection.
If you expect all values to be equal to 1./100, you could for instance call assert_allclose(..., 1e-2) on the values, instead of printing them.
Also, you can add the unit test in a different commit of the same pull request, it can make things easier to review.

@XavierAudier
Copy link
Contributor Author

Hi,
Sorry I'll fix that. It's my first time contributing to a repository I'm still not used to it.
Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants