Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While making pytest work as well as pyCharm testrunner, fixed some directory and project stuff. #2

Merged
merged 1 commit into from
Dec 28, 2023
Merged

While making pytest work as well as pyCharm testrunner, fixed some directory and project stuff. #2

merged 1 commit into from
Dec 28, 2023

Conversation

lisad
Copy link
Owner

@lisad lisad commented Dec 24, 2023

  • First thing blocking pytest was that the library wasn't installed in pip. Provides library definition in pyproject.toml, then "run pip install -e ."
  • Added more setup info to README.md because of these steps.
  • Then pytest wasn't working because of the relative directory to the fixture. Improved that by figuring out what the present directory is before loading fixture.
  • While doing that, made the Phase object setup more flexible: source file can be a string or path object.
  • Using the pytest builtin fixture for a temporary directory for output is cleaner

@lisad
Makes pytest work as well as testing in pycharm. Provides library def…
910292e 
…inition in pyproject.toml. Uses classier temp directory in test
@lisad lisad requested a review from jeffkole December 24, 2023 20:11
@lisad lisad merged commit 910292e into main Dec 28, 2023
@lisad lisad mentioned this pull request Dec 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkole jeffkole jeffkole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisad @jeffkole