Pass view attach/detach events to the Item #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisawray
approved these changes
Oct 7, 2019
ValCanBuild
requested changes
Oct 8, 2019
| @@ -466,6 +466,22 @@ public void onItemMoved(@NonNull Group group, int fromPosition, int toPosition) | |||
| notifyItemMoved(groupAdapterPosition + fromPosition, groupAdapterPosition + toPosition); | |||
| } | |||
|
|
|||
| @Override | |||
| public void onViewAttachedToWindow(@NonNull VH holder) { | |||
There was a problem hiding this comment.
this looks great, but could you please move these functions to be just under the onFailedToRecycleView one so that we can group the RecyclerView.Adapter overloads in one place
There was a problem hiding this comment.
That makes sense. They should be in the correct position now.
ValCanBuild
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an
Itemthat requires to know if it's attached or not to the window to know when to start/stop animations and UI updates.The simplest solution is to override the
RecyclerView::Adapter::onViewAttachedToWindow(and the detach equivalent) method and pass it to theItem.What are your thoughts on this? If this seems reasonable, it would be nice to have it in the library.