Raise different exception on processing timed out message #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GinTR1k
changed the title
GinTR1k
force-pushed
the
improve-exception-on-processed-message
branch
11 times, most recently
from
915ada4
to
917de51
Compare
Codecov ReportBase: 86.75% // Head: 87.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 86.75% 87.51% +0.76%
==========================================
Files 33 33
Lines 1963 2019 +56
Branches 226 231 +5
==========================================
+ Hits 1703 1767 +64
+ Misses 193 186 -7
+ Partials 67 66 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
GinTR1k
force-pushed
the
improve-exception-on-processed-message
branch
from
917de51
to
0a65c90
Compare
atugushev
reviewed
Oct 6, 2020
Conflicts: ansq/tcp/types/message.py tests/test_read_messages.py
There is no way a message could appear in messages() after fin() and touch()
atugushev
reviewed
Sep 18, 2022
| return response | ||
| async def wrapper(message: "NSQMessage", *args: Any, **kwargs: Any) -> Any: | ||
| if message.is_processed: | ||
| raise RuntimeWarning(f"Message id={message.id} has already been processed") |
There was a problem hiding this comment.
While RuntimeWarning is technically an exception, it should not be raised manually in code, because conceptually it belongs to the warnings mechanism. This must be fixed in a following-up PR.
atugushev
changed the title
|
Thanks @GinTR1k for the improvement and @Ivashkaization for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.