Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds shadowRootOptions feature #1148

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Adds shadowRootOptions feature #1148

merged 1 commit into from
Feb 4, 2021

Conversation

sorvell
Copy link
Member

@sorvell sorvell commented Feb 4, 2021

This is a slightly simpler alternative for customizing shadow root options than implementing createRenderRoot.

Reference Issue

Fixes #1147.

This is a slightly simpler alternative for customizing shadow root options than implementing `createRenderRoot`. Fixes #1147.
Copy link
Contributor

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to format, but change looks good

@sorvell sorvell merged commit eeadf21 into master Feb 4, 2021
@sorvell sorvell deleted the shadow-root-options branch February 4, 2021 17:42
@justinfagnani justinfagnani added this to the 2.5.0 milestone Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shadowRootOptions for more easily customizing shadowRoot
2 participants