Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lit-labs/compiler to the v3 labs page #1175

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented Aug 18, 2023

Umbrella Issue: lit/lit#189
RFC: lit/rfcs#21
Specific Issue: lit/lit#4101

Context

This is required as part of the initial pre-release with Lit 3.0

Test plan

Tested manually by viewing the labs v3 page.

https://pr1175-d24c562---lit-dev-5ftespv5na-uc.a.run.app/docs/v3/libraries/labs/

Screenshot:

Screenshot 2023-08-18 at 12 08 40 PM

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1175-d24c562---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1175-f19bf89---lit-dev-5ftespv5na-uc.a.run.app/

@justinfagnani
Copy link
Contributor

@AndrewJakubowicz looks like a GitHub cache error on the check links runner, but I also expect that to fail on the npm link which is returning a 404. I suppose we should wait on a publish before merging.

@AndrewJakubowicz
Copy link
Contributor Author

The compiler can now be npm installed. Merging!

@AndrewJakubowicz AndrewJakubowicz merged commit 79c3407 into main Oct 2, 2023
12 of 15 checks passed
@AndrewJakubowicz AndrewJakubowicz deleted the add-labs-compiler branch October 2, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants