Blocking playground renderer #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
approved these changes
Nov 11, 2020
| `(${shared.html.length} < ${html.length} bytes)` | ||
| ); | ||
| } | ||
| shared.length[0] = length; |
There was a problem hiding this comment.
What is .length here? It reads oddly to see that name indexed like this.
| type: 'shutdown'; | ||
| } | ||
|
|
||
| export class BlockingRenderer { |
|
|
||
| export type WorkerMessage = Handshake | Render | Shutdown; | ||
|
|
||
| export interface Handshake { |
There was a problem hiding this comment.
nit: add Message suffix
| export interface Handshake { | ||
| type: 'handshake'; | ||
| html: Uint8Array; | ||
| length: Int32Array; |
There was a problem hiding this comment.
I see, about my question about the length name... Maybe name these like lengthBuffer or lengthData to make it more clear?
| @@ -37,7 +37,7 @@ export class Reaper { | |||
|
|
|||
| private endKeepAlive() { | |||
| this.pending--; | |||
| if (this.pending == 0) { | |||
| if (this.pending === 0) { | |||
There was a problem hiding this comment.
fyi, 11ty recently added beforeBuild and afterBuild events: https://www.11ty.dev/docs/events/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither markdown code fences, nor shortcodes in HTML files, support async rendering, so this makes them work by rendering in a blocking fashion. A little absurd maybe?
Atomics.wait.{% highlight %}shortcode with this renderer.updateComplete, instead of spawning a new tab for each render (way faster).