Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add i18n feature #817

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

add i18n feature #817

wants to merge 49 commits into from

Conversation

novenn
Copy link
Contributor

@novenn novenn commented May 8, 2022

translate docs/get-started into chinese

translate docs/components/overview into chinese

translate docs/components/defining to chinese

translate docs/components/rendering into chinese

novenn added 3 commits May 8, 2022 09:21
translate docs/get-started into chinese

translate docs/components/overview into chinese

translate docs/components/defining to chinese

translate docs/components/rendering into chinese

remove dependences

sss
@justinfagnani
Copy link
Contributor

Wow, thanks for this work @novenn!!

We've been talking about how to approach internationalization for a while (brief issue at #355)

We have a lot of things to figure out around process and infrastructure, but this definitely addresses some important parts of the infrastructure!

I would love to accept this contribution soon, but I'm not sure when we'll know enough to be able to do so. Because we're a Google project, it's quite likely that we have to adhere to company policy on accepting translations, setting up reviews, etc. This PR really motivates us to figure out the process parts. We'll start outlining more detailed requirements and collecting answers as we get them. I think we should do this in #355.

Thanks again!!

@justinfagnani
Copy link
Contributor

/gcbrun

@arthurevans
Copy link
Contributor

Also, the website has a creative commons license that allows for derivative works. In the past people have created and hosted their own localized versions of the Polymer docs, which were released under the same license. I realize not everyone is willing or able to host a website, but that's one possibility.

@justinfagnani
Copy link
Contributor

@novenn I tried to run the action to deploy a preview and it failed on npm install. We use npm ci so the package.json and package-lock.json files have to match.

Can you resolve conflicts and update the package locks with npx lerna bootstrap in the root folder?

@novenn
Copy link
Contributor Author

novenn commented May 14, 2022

@novenn I tried to run the action to deploy a preview and it failed on npm install. We use npm ci so the package.json and package-lock.json files have to match.

Can you resolve conflicts and update the package locks with npx lerna bootstrap in the root folder?

i have run the npx lerna bootstrap and pushed.

@novenn
Copy link
Contributor Author

novenn commented May 15, 2022

/gcbrun

how to execute /gcbrun

@novenn
Copy link
Contributor Author

novenn commented Jul 3, 2022

preview of chinese version document https://lit.novenn.com/zh-CN/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants