Wrapper test elements + runtime tests #3384

sorvell · 2022-10-21T00:59:09Z

Adds tests elements that stress property types, events, and slots.
Adds wrappers and runtime tests for the new elements for Vue and React

Previously: `{onAChanged: 'a-changed'}` Now: `{onAChanged: 'a-changed' as EventName<CustomEvent<unknown>>}`

Removing `.ts` wrapper as we now generate a `.vue` SFC.

* update vite/vue deps * properly type events * configure defaults using the Vue convention: whenever unset, revert to default value.

* element-events: for testing events * element-props: for testing property types * element-slots: for testing slotting.

changeset-bot · 2022-10-21T00:59:12Z

🦋 Changeset detected

Latest commit: 78bc07d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@lit-labs/gen-wrapper-angular	Patch
@lit-labs/gen-wrapper-react	Patch
@lit-labs/gen-wrapper-vue	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kevinpschaaf

LGTM, just a few cleanup / fixes.

kevinpschaaf · 2022-10-21T22:43:58Z

packages/labs/gen-wrapper-react/test-output/package.json

@@ -71,7 +71,7 @@
        "build",
        "../../../tests:build"
      ],
-      "command": "node ../../../tests/run-web-tests.js \"tests/**/*_test.js\" --config ../../../tests/web-test-runner.config.js",
+      "command": "node ../../../tests/run-web-tests.js \"tests/**/(tests|*_test).js\" --config ../../../tests/web-test-runner.config.js",


tests.js pulls in all the _test files, so doesn't this run them all twice? Why have the tests.js file?

It's because we need an entrypoint for rollup? If so, then seems like that's the only thing that should be here?

kevinpschaaf · 2022-10-21T22:56:27Z

packages/labs/gen-wrapper-vue/src/lib/wrapper-module-template-sfc.ts

@@ -111,6 +111,9 @@ const wrapperTemplate = (
 ) => {
  const {tagname, events, reactiveProperties} = declaration;
  return javascript`
+    <script lang="ts">
+      export * from '${wcPath}';


Let's change this to export the type references that were imported.

github-actions · 2022-10-23T01:16:57Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -5% - +6% (-1.28ms - +1.54ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 102.00ms - 108.31ms
lit-html-kitchen-sink: unsure 🔍 -6% - +4% (-2.69ms - +1.53ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -5% - +3% (-0.56ms - +0.36ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -0% - +6% (-0.17ms - +4.14ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -7% - +1% (-5.35ms - +0.77ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 942.02ms - 963.62ms
lit-html-kitchen-sink: unsure 🔍 -5% - +4% (-6.01ms - +5.06ms)
^{this-change vs tip-of-tree}
lit-html-repeat: faster ✔ 1% - 6% (3.83ms - 18.56ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +5% (-1.10ms - +7.26ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-6.87ms - +20.66ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 963.14ms - 983.91ms
reactive-element-list: unsure 🔍 -1% - +2% (-13.53ms - +15.29ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 106.0.5249.119
Sample size: 50
Built by: Benchmarks #3983
Commit: 8e1d10a

render

Version	Avg time	vs
	102.00ms - 108.31ms	-

update

Version	Avg time	vs
	942.02ms - 963.62ms	-

update-reflect

Version	Avg time	vs
	963.14ms - 983.91ms	-

lit-html-kitchen-sink

Browser: chrome-headless 106.0.5249.119
Sample size: 30
Built by: Benchmarks #3983
Commit: 8e1d10a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	40.24ms - 43.21ms	-	unsure 🔍 -6% - +4% -2.69ms - +1.53ms	unsure 🔍 -7% - +3% -2.97ms - +1.25ms
tip-of-tree tip-of-tree	40.81ms - 43.80ms	unsure 🔍 -4% - +6% -1.53ms - +2.69ms	-	unsure 🔍 -6% - +4% -2.39ms - +1.84ms
previous-release previous-release	41.08ms - 44.08ms	unsure 🔍 -3% - +7% -1.25ms - +2.97ms	unsure 🔍 -4% - +6% -1.84ms - +2.39ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	108.27ms - 117.32ms	-	unsure 🔍 -5% - +4% -6.01ms - +5.06ms	unsure 🔍 -6% - +4% -6.82ms - +4.30ms
tip-of-tree tip-of-tree	110.08ms - 116.45ms	unsure 🔍 -5% - +5% -5.06ms - +6.01ms	-	unsure 🔍 -5% - +3% -5.33ms - +3.75ms
previous-release previous-release	110.82ms - 117.29ms	unsure 🔍 -4% - +6% -4.30ms - +6.82ms	unsure 🔍 -3% - +5% -3.75ms - +5.33ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	25.94ms - 28.30ms	-	unsure 🔍 -5% - +6% -1.28ms - +1.54ms	unsure 🔍 -7% - +5% -2.04ms - +1.28ms
tip-of-tree tip-of-tree	26.22ms - 27.76ms	unsure 🔍 -6% - +5% -1.54ms - +1.28ms	-	unsure 🔍 -7% - +3% -1.92ms - +0.89ms
previous-release previous-release	26.33ms - 28.67ms	unsure 🔍 -5% - +8% -1.28ms - +2.04ms	unsure 🔍 -3% - +7% -0.89ms - +1.92ms	-

lit-html-repeat

Browser: chrome-headless 106.0.5249.119
Sample size: 30
Built by: Benchmarks #3983
Commit: 8e1d10a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.83ms - 12.39ms	-	unsure 🔍 -5% - +3% -0.56ms - +0.36ms	unsure 🔍 -4% - +3% -0.50ms - +0.38ms
tip-of-tree tip-of-tree	11.84ms - 12.57ms	unsure 🔍 -3% - +5% -0.36ms - +0.56ms	-	unsure 🔍 -4% - +4% -0.46ms - +0.54ms
previous-release previous-release	11.83ms - 12.51ms	unsure 🔍 -3% - +4% -0.38ms - +0.50ms	unsure 🔍 -4% - +4% -0.54ms - +0.46ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	306.34ms - 314.78ms	-	faster ✔ 1% - 6% 3.83ms - 18.56ms	unsure 🔍 -5% - +0% -15.55ms - +0.92ms
tip-of-tree tip-of-tree	315.73ms - 327.79ms	slower ❌ 1% - 6% 3.83ms - 18.56ms	-	unsure 🔍 -2% - +4% -5.41ms - +13.17ms
previous-release previous-release	310.80ms - 324.95ms	unsure 🔍 -0% - +5% -0.92ms - +15.55ms	unsure 🔍 -4% - +2% -13.17ms - +5.41ms	-

lit-html-template-heavy

Browser: chrome-headless 106.0.5249.119
Sample size: 50
Built by: Benchmarks #3983
Commit: 8e1d10a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	65.72ms - 68.92ms	-	unsure 🔍 -0% - +6% -0.17ms - +4.14ms	unsure 🔍 -2% - +6% -1.10ms - +3.83ms
tip-of-tree tip-of-tree	63.90ms - 66.78ms	unsure 🔍 -6% - +0% -4.14ms - +0.17ms	-	unsure 🔍 -5% - +3% -2.99ms - +1.74ms
previous-release previous-release	64.08ms - 67.84ms	unsure 🔍 -6% - +2% -3.83ms - +1.10ms	unsure 🔍 -3% - +5% -1.74ms - +2.99ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	133.28ms - 139.53ms	-	unsure 🔍 -1% - +5% -1.10ms - +7.26ms	unsure 🔍 -2% - +4% -2.97ms - +5.99ms
tip-of-tree tip-of-tree	130.55ms - 136.10ms	unsure 🔍 -5% - +1% -7.26ms - +1.10ms	-	unsure 🔍 -4% - +2% -5.82ms - +2.67ms
previous-release previous-release	131.69ms - 138.11ms	unsure 🔍 -4% - +2% -5.99ms - +2.97ms	unsure 🔍 -2% - +4% -2.67ms - +5.82ms	-

reactive-element-list

Browser: chrome-headless 106.0.5249.119
Sample size: 50
Built by: Benchmarks #3983
Commit: 8e1d10a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	70.61ms - 74.56ms	-	unsure 🔍 -7% - +1% -5.35ms - +0.77ms	unsure 🔍 -5% - +3% -3.47ms - +2.34ms
tip-of-tree tip-of-tree	72.54ms - 77.21ms	unsure 🔍 -1% - +7% -0.77ms - +5.35ms	-	unsure 🔍 -2% - +7% -1.44ms - +4.89ms
previous-release previous-release	71.02ms - 75.28ms	unsure 🔍 -3% - +5% -2.34ms - +3.47ms	unsure 🔍 -6% - +2% -4.89ms - +1.44ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	947.23ms - 966.00ms	-	unsure 🔍 -1% - +2% -6.87ms - +20.66ms	unsure 🔍 -0% - +2% -4.00ms - +22.23ms
tip-of-tree tip-of-tree	939.66ms - 959.79ms	unsure 🔍 -2% - +1% -20.66ms - +6.87ms	-	unsure 🔍 -1% - +2% -11.38ms - +15.83ms
previous-release previous-release	938.34ms - 956.66ms	unsure 🔍 -2% - +0% -22.23ms - +4.00ms	unsure 🔍 -2% - +1% -15.83ms - +11.38ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	996.51ms - 1014.45ms	-	unsure 🔍 -1% - +2% -13.53ms - +15.29ms	unsure 🔍 -1% - +2% -13.55ms - +16.99ms
tip-of-tree tip-of-tree	993.33ms - 1015.88ms	unsure 🔍 -2% - +1% -15.29ms - +13.53ms	-	unsure 🔍 -2% - +2% -15.89ms - +17.57ms
previous-release previous-release	991.40ms - 1016.12ms	unsure 🔍 -2% - +1% -16.99ms - +13.55ms	unsure 🔍 -2% - +2% -17.57ms - +15.89ms	-

_{tachometer-reporter-action v2 for Benchmarks}

kevinpschaaf

Other than one suggested test addition, LGTM

kevinpschaaf · 2022-10-24T21:47:14Z

packages/labs/test-projects/test-element-a/src/element-events.ts

+ * My awesome element
+ * @fires string-custom-event {CustomEvent<string>} A custom event with a string payload
+ * @fires number-custom-event {CustomEvent<number>} A custom event with a number payload
+ * @fires my-detail-custom-event {CustomEvent<MyDetail>} A custom event with a MyDetail payload.


Can we add a

* @fires template-result-custom-event {CustomEvent<TemplateResult>}

and dispatch an event like

fromNode.dispatchEvent(new CustomEvent('template-result-custom-event', {detail: html``}))

so that we can exercise type references from an external package that's not otherwise imported into the generated source?

Note that this will point out an obvious catch-22: I expect the TemplateResult reference in the @fires will cause the analyzer to error because TemplateResult symbol isn't imported into the current file, which I believe is the right thing to do, since we can't otherwise know what that identifier was actually referring to. But adding an import type {TemplateResult} from 'lit'; will fail compilation because it's not actually used in the TS source, only the comment.

We can either silence the unused symbol warning, or (better imo) just require the user to actually use the imported symbol, ala new CustomEvent('template-result-custom-event', {detail: html`` as TemplateResult}).

Either way, this will allow us to test that we get the proper import {TemplateResult} from 'lit' in the generated source.

Imports and exports types for properties.

* Move the render function to the end of lit-html (#3284) * Move the render function to the end of lit-html Believe it or not, this is part of some work to better integrate with closure compiler's dead code elimination. * Add an empty changeset. * Fix empty changeset. * Task: Do not reset task value or error on pending (#3283) * [infra] Enable IntersectionController and PerformanceController tests (#3291) Add intersection controller and performance controller tests to CI - skipping Safari. Deflake Firefox intersection controller tests. * [labs/ssr] fix Hydrating LitElements example markup (#3298) * [labs/observers] Fix controllers not observing target if initialized after host connected (#3293) Co-authored-by: Steve Orvell <sorvell@google.com> * [labs/analyzer] Refactor Analyzer into better fit for use in plugins (#3288) * Refactor context * Make Analyzer implement AnalyzerInterface rather than has-a AnalyzerContext * Add PackageInfo and pass to getModule * Add changeset. Minor cleanup. * Fix cli test * Normalize rootDir * Refactor PackageAnalyzer into factory * Address feedback. Minor cleanup. * Slack -> Discord readme (#3307) * [@labs/gen-wrapper-react] TestOutput links to monorepo for dependencies (#3310) * test-output points to the same react dependency * remove types from tsconfig in labs_react * restore multiple react versions * [labs/cli] Lazily install and locally version localize (#2936) * [cli] Lazily install and locally version localize Also merge the two localize commands into one They have just about the same deps and share some setup and teardown code, there's no win in putting them in separate modules. * Use better assertions of no errors. This should print out the stderr output in the case there was some. * Fix error output The .finally fork of the Promise.race result promise was causing an early exit from node before the ordinary uvu error handling could kick in. * Fix failing test It was passing locally because the cwd was set to the CLI directory, but we want to run in a fake workspace directory. * Add an installation message when running npm install. * Changeset * Use try/finally instead of promise methods * Move localize command into its own package. * Task add onComplete and onError (#3287) * [lit] Add "types" to package exports (#3320) * [lit-html] Add `isServer` environment checker module (#3318) Adds an `isServer` variable export to `lit` and `lit-html/is-server.js` which will be `true` in Node and `false` in the browser. This can be used when authoring components to change behavior based on whether or not the component is executing in an SSR context. * [labs/analyzer] Adds support for analyzing JavaScript packages (#3304) * Add support for analyzing JavaScript packages * Fix customElements.define detection, add comments. * Better comments / error handling * Revert accidental SSR changes * Add optional/non-null to model * Run analyzer_test in JS. Add changeset. * Fix gen-wrapper-angular * Fix another inadvertant SSR change * Address review feedback. * Add test based on feedback. * [labs/observers] Improve controllers value type from unknown to generic (#3294) Fix value property of type `unknown` on exported controllers. The type of `value` is now generic and can be inferred from the return type of your passed in `callback`. The default callback `() => true` was removed, and is now undefined by default. * [labs/react] Provide explicit return type from createComponent (#3163) * create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * add event listeners * checkout readmes from main * remove as casting in render * remove anys * create minimal JSXInterface for library * save types * jsxmodule * attrubtes over htmlprops * explicit return of element types * move comments * minimal references to window * remove ref cast * remove code changes, type only changes * update changeset * ideal * roll back to minimal amount of changes * types at top of file * better comment * rename userprops to element props * add types to test refs * add extends to exported element props type * pause to sync * add comments, more specific names for events * update EventNames downstream * include package types in tsconfig * undo * tests pass with no extra exports * exposing element props successful * wow only the exposed ReactWebComponent fails * add react types to workspaces * move types to dev deps * remove artifacts from different PR * remove rollup artifact from other PR * declare types in test-output tsconfig * capitals for classes * add export to ReactWebComponent * a/b the types array in test-output * add test for ReactWebComponent type * simplify test * componentProps to ReactComponentProps * type only test * update description * unblocked gen-wrapper-react * add comment for type test * restore modified files * restore modified files, again * remove types tsconfig property * only export what's required * remove old code * add return type * remove extra line in index * [labs/observers] observed targets are re-observed when the host is reconnected (#3321) Controllers now track all observed targets and will restore observing targets when host is reconnected. Fixes: #2902 * [labs/observers] Add unobserve method to ResizeController and IntersectionController (#3323) Add unobserve method to `ResizeController` and `IntersectionController` to match native API. Fixes: #3237 * [labs/gen-utils] Add core packages to testing install with link (#3330) * [infra] Update changesets and package for release (#3332) * Update changesets for release * Update cli-localize package.json for release * Add @lit-labs/cli-localize to changeset * Remove gen-wrapper-angular from changesets (#3336) * Version Packages (#3337) * Unpin Node version for windows-tools test (#3338) * [labs/react] introduce a options object (#2988) * create params object * add changeset * update readme * eeek, this requires generics * found correct return type * more refined type * add ref typing * adjust ref typings * type forwarded instance * expose types at top of file * organize types * no react window module * no react window module * more merge main * initial params bag * add changeset, remove commented code * ReactOrParams * destructure params * update tests, react is optional * remove optional react * remove default react * change is a patch * forgot options.react * [labs/react] Update REAMDE for function overload (#3350) * initial commit * add empty changeset * [@lit-labs/router] add Routes.link tests (#3348) * [gen-manifest] Initial impl of CEM generator (#2990) * [gen-manifest] Initial impl of CEM generator Reset changelog Fix readme * Sync with monorepo changes * Fix comments * Add variable declaration * Update to changes on main. * Fix version for gen-utils * Fix analyzer version * Fix and add tests for type reference serialization * [labs/analyzer] Cache Module models based on dependencies. (#3333) * Cache Module models based on dependencies. * Cleanup and add changeset. * Windows path fixes * Normalize all the paths for Windows * Move moduleCache from module var to Analyzer field. * Add missing wireit input * Add missing wireit output * Fix typo in task README (#3385) * Initializers are copied but separate from superclass initializers (#3374) Initializers are copied but separate from superclass initializers, fixes #/3373. * Example code had an h1 tag closed by an h3 tag (#3392) I changed the h3 tag to be an h1 tag to match the other routes * Improvements to Vue/React wrappers (#3377) Updates react wrapper to correctly type events Update vue wrapper * update vite/vue deps * properly type events * configure defaults using the Vue convention: whenever unset, revert to default value. * Wrapper test elements + runtime tests (#3384) * Adds additional test elements * element-events: for testing events * element-props: for testing property types * element-slots: for testing slotting. * Adds property types to angular wrapper * [@labs/react] certain attributes should be removed when undefined or null (#3128) * add sieve for boolean attributes * unchange stuff that isn't required yet * add changeset * no sieve, use hasAttribute * use hasOwnProperty * boolean attributes should test as null * pause * let react handle the nullifies * remove unnecessary return * add comment, update changeset * remove 232 * cascade logic over nested * update comments * don't watch for disabled * show test updates and output * hidden attr is alright * passing tests * set HTMLPrototype undefined values to empty string * id is the special case * add tests for properties * update tests for properties * remove nested iffs from set property * format * set as empty string * change value, don't assign * value as str * remove attribute if undefined * set value as string on htmlelement attr * match vanilla react behavior * order ifs by cost, comment alternatives * forgot return * checkpoint * sync with example gist * draggable is null * checkpoint * update tests, wrappedEl vs el * test div against web component * remove extra lines * update changeset * include unwrapped web component x-foo * add null checks at end of attribute checks * add comments, add undefined tests after boolean * typo, enumerated * add null checkes to test, add ts-expect-errors * add test ordering * forgot one truthy test * [infra] Use new projectV2 object in issue workflow (#3419) * Add lit to changeset along side reactive-element (#3422) * Version Packages (#3423) * Update chromedriver to 107 for benchmark tests (#3427) * Update chromedriver to 107 for benchmark tests * [labs/virtualizer] Fix width inheritance calculation (issue #3400) (#3424) * Added a test to demonstrate virtualizer width inheritance bug in #3400 * Applied the fix to Virtualizer _updateView to interpret width correctly. * Added changeset describing the fix for #3400. * [labs/virtualizer] Export event classes through a new events.js (#3430) * Added an events.js to export the RangeChangedEvent and VisibilityChangedEvent classes. * Point to events.js to get the event classes now and moved the custom Range interface into there. * Added events.js files to package.json's files property and the wireit outputs for build:ts. * [labs/context] Rename context decorators to consume and provide (#3398) * [@labs/react] Filter __forwardedRef in prod build (#3409) * [labs/react] Filter __forwardedRef in prod build * rebased from main, branched from react-forwarded-ref * added changeset * update ref setting * add dunders back in * add comments, update changeset * iterrate userprops Co-authored-by: Justin Fagnani <justinfagnani@google.com> * [labs/context] Make @consume decorator work with optional fields (#3399) * [labs/context] Rename ContextKey to Context (#3404) * Allow ContextProvider to be added lazily and still work with ContextRoot (#3434) * [infra] Fix npm install with version 9 (#3448) * Fix dep on missing folder. Fixes npm install on npm 9. * Add empty changeset * Implement `lit init element` (#3248) Co-authored-by: Justin Fagnani <justinfagnani@google.com> * Logo dark mode support (#3457) * Update logo.svg * empty changeset * lit logo dark mode * add light theme too * fix file locations * use srcset * slack to discord badge * Gitignore build output files from virtualizer (#3454) * Gitignore build output files from virtualizer * add prettierignore files * [labs/analyzer] Add lazy Declaration analysis, Reference dereferencing, and Superclass support (#3380) * Fix comment * Use NODE_OPTIONS=--enable-source-maps * Make declarations lazy * Analyze exports and add ability to dereference References to them * Add superClass reference analysis * Add changeset * fixup! Use NODE_OPTIONS=--enable-source-maps * Fix references to ImportTypes * Add CEM generation to CLI * Fix type import references * Address review feedback. * Fix path normalization on Windows * Updates based on feedback. * Add getSpecifierString to another site. * [labs/gen-manifest] Adds `exports` and more metadata to manifest generator (#3464) * Adds exports to manifest generator Also fixes a few bugs in export analysis and adds better tests. * Add `@slot`, `@cssProp`, and `@cssPart` to manifest generator * Fix config to make JS program analysis faster. * Add windows line ending to regex * Add changeset * Additional Windows line endings fix. * Add support for parsing description, summary, & deprecated * Add more exports support * Emit summary & description in manifest. * Gitignore build output files from virtualizer (#3454) * Gitignore build output files from virtualizer * add prettierignore files * Add the js.map extension to the files property for events.js. * update .prettierignore and .gitignore to include events.js.map Co-authored-by: Peter Burns <rictic@google.com> Co-authored-by: Elliott Marquez <5981958+e111077@users.noreply.github.com> Co-authored-by: Andrew Jakubowicz <ajakubowicz@google.com> Co-authored-by: Michael Potter <mgp140@gmail.com> Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Brian Taylor Vann <brian.t.vann@gmail.com> Co-authored-by: Augustine Kim <augustinekim@google.com> Co-authored-by: Lit Robot <98060554+lit-robot@users.noreply.github.com> Co-authored-by: Nick Cipriani <nick.cipriani@gmail.com> Co-authored-by: Brendan Baldwin <brendan@usergenic.com> Co-authored-by: Justin Fagnani <justinfagnani@google.com>

Steven Orvell added 12 commits October 19, 2022 11:08

Updates react wrapper to correctly type events

9d7c277

Previously: `{onAChanged: 'a-changed'}` Now: `{onAChanged: 'a-changed' as EventName<CustomEvent<unknown>>}`

Remove cruft

1f218c4

Removing `.ts` wrapper as we now generate a `.vue` SFC.

Update vue wrapper

ec09073

* update vite/vue deps * properly type events * configure defaults using the Vue convention: whenever unset, revert to default value.

Add changeset.

62f5a08

Adds additional test elements

6d27a79

* element-events: for testing events * element-props: for testing property types * element-slots: for testing slotting.

react: only import EventName type helper if it will be used.

35fb00d

Merge branch 'wrapper-vue-react-fixes' into wrapper-test-elements

0f908c7

Simplify element-props

92640c7

vue wrapper: fix gitignore and check in goldens.

8499a95

Add runtime tests for vue wrappers

2a00728

Adds runtime tests for react wrappers

799c138

Add missing vue wrapper runtime test

98f1c9e

sorvell requested a review from kevinpschaaf October 21, 2022 00:59

sorvell requested a review from justinfagnani as a code owner October 21, 2022 00:59

kevinpschaaf changed the base branch from main to wrapper-vue-react-fixes October 21, 2022 22:37

kevinpschaaf approved these changes Oct 21, 2022

View reviewed changes

Steven Orvell added 6 commits October 21, 2022 17:39

Merge branch 'main' into wrapper-vue-react-fixes

26b4d69

Address review feedback

f09216e

Merge branch 'wrapper-vue-react-fixes' into wrapper-test-elements

6159e0a

Fix exports

2bbc6da

Address review feedback.

fce6140

Merge branch 'wrapper-vue-react-fixes' into wrapper-test-elements

be0a775

Steven Orvell added 3 commits October 23, 2022 06:23

Address review feedback.

703b2be

Merge branch 'wrapper-vue-react-fixes' into wrapper-test-elements

1462401

Update golden.

64308cf

kevinpschaaf approved these changes Oct 24, 2022

View reviewed changes

Steven Orvell added 2 commits October 25, 2022 09:08

Merge branch 'main' into wrapper-vue-react-fixes

675c1be

Address review feedback.

038c9f8

Steven Orvell added 2 commits October 25, 2022 09:19

Merge branch 'wrapper-vue-react-fixes' into wrapper-test-elements

2ccec49

Add test based on review feedback.

776003f

Base automatically changed from wrapper-vue-react-fixes to main October 25, 2022 22:13

Steven Orvell added 5 commits October 25, 2022 18:19

Merge branch 'main' into wrapper-test-elements

34b412f

Update vite config golden.

4e4f888

Add angular update-goldens command and update them.

b674ddf

Update Angular wrapper

10b5100

Imports and exports types for properties.

Add changeset.

78bc07d

sorvell merged commit 9f80264 into main Oct 26, 2022

sorvell deleted the wrapper-test-elements branch October 26, 2022 19:51

This was referenced Nov 3, 2022

Version Packages #3421

Closed

Version Packages #3423

Merged

kevinpschaaf mentioned this pull request Nov 16, 2022

[labs/gen-manifest] Adds exports and more metadata to manifest generator #3464

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrapper test elements + runtime tests #3384

Wrapper test elements + runtime tests #3384

sorvell commented Oct 21, 2022 •

edited by kevinpschaaf

changeset-bot bot commented Oct 21, 2022 •

edited

kevinpschaaf left a comment

kevinpschaaf Oct 21, 2022

kevinpschaaf Oct 21, 2022

sorvell Oct 23, 2022

kevinpschaaf Oct 21, 2022

sorvell Oct 23, 2022

github-actions bot commented Oct 23, 2022 •

edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

kevinpschaaf left a comment

kevinpschaaf Oct 24, 2022

sorvell Oct 25, 2022

Wrapper test elements + runtime tests #3384

Wrapper test elements + runtime tests #3384

Conversation

sorvell commented Oct 21, 2022 • edited by kevinpschaaf

changeset-bot bot commented Oct 21, 2022 • edited

🦋 Changeset detected

kevinpschaaf left a comment

Choose a reason for hiding this comment

kevinpschaaf Oct 21, 2022

Choose a reason for hiding this comment

kevinpschaaf Oct 21, 2022

Choose a reason for hiding this comment

sorvell Oct 23, 2022

Choose a reason for hiding this comment

kevinpschaaf Oct 21, 2022

Choose a reason for hiding this comment

sorvell Oct 23, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 23, 2022 • edited

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

kevinpschaaf left a comment

Choose a reason for hiding this comment

kevinpschaaf Oct 24, 2022

Choose a reason for hiding this comment

sorvell Oct 25, 2022

Choose a reason for hiding this comment

sorvell commented Oct 21, 2022 •

edited by kevinpschaaf

changeset-bot bot commented Oct 21, 2022 •

edited

github-actions bot commented Oct 23, 2022 •

edited