[web] edit styles #168
Merged
[web] edit styles #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
serenaqiaoo
reviewed
Jun 24, 2023
serenaqiaoo
reviewed
Jun 24, 2023
Comment on lines
196
to
+201
| {#if $isAgentFormEditing} | ||
| <Button type="button" class="" color="light" on:click={() => isAgentFormEditing.set(false)} | ||
| >Cancel</Button | ||
| > | ||
| {/if} | ||
| <Button type="submit" class="">Submit</Button> | ||
| <Button type="submit" size="xl">Submit</Button> |
There was a problem hiding this comment.
nit: keep the size/style of the buttons consistent
serenaqiaoo
reviewed
Jun 24, 2023
| </div> | ||
| <div class="scroller"> | ||
| {#each characters as character, i} | ||
| <a href="agent/{character.id}"> |
There was a problem hiding this comment.
The focus area of the avatar seems too larger than the size of the avatar.
Like if click the area in the middle of C and A-Serena, the agent page will be opened.
Tagging @serenaqiaoo myself here so I will fix this in another PR.
serenaqiaoo
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dashboardpageagent profilepageagent profile editpagecreate conversationpage