Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix async sessions, Pydantic V2 #2298

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

geeshta
Copy link
Contributor

@geeshta geeshta commented Sep 11, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR

Description

  • Fixed documentation examples under /contrib/sqlalchemy

  • Added expire_on_commit=False to prevent errors from mixing sync and async context

  • Updated Pydantic usage for V2

Close Issue(s)

No issues on GitHub but two threads on Discord

@geeshta geeshta requested review from a team as code owners September 11, 2023 18:24
@geeshta geeshta changed the title Update docs docs: Fix async sessions, Pydantic V2 Sep 11, 2023
@Goldziher
Copy link
Contributor

@all-contributors add @geeshta docs

@allcontributors
Copy link
Contributor

@Goldziher

I've put up a pull request to add @geeshta! 🎉

@Goldziher Goldziher merged commit 9b950ae into litestar-org:main Sep 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants