Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of Threader.finish() #1

Closed
pradeepg26 opened this issue Dec 12, 2015 · 1 comment
Closed

Fix implementation of Threader.finish() #1

pradeepg26 opened this issue Dec 12, 2015 · 1 comment

Comments

@pradeepg26
Copy link

Threader.finish() is using Thread.sleep() which is inefficient. Can be replaced with ExecutorService.awaitTermination()
pradeepg26 pushed a commit that referenced this issue Dec 15, 2015
Adds a Batcher class - Closes #1
c5ca7d3
@mattayres
Copy link
Contributor

This is actually by design to allow for submit reentry. The sleep is only in the calling thread and has a very nominal overhead, so it hardly matters here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattayres @pradeepg26