fix: ignore invalid schema properties

Author: sharkboy1976

lib/revalidator.js

@@ -326,9 +326,11 @@
         if (schema.properties) {
             props = schema.properties;
             for (p in props) {
-                if (props.hasOwnProperty(p)) {
+                if (props.hasOwnProperty(p) && getType(props[p]) === 'object') {
                     visitedProps.push(p);
                     validateProperty(object, object[p], p, props[p], options, errors);
+                } else {
+                    console.log('Schema invalid. Property ' + p + ' is not of type object, actual type: ' + getType(props[p]));
                 }
             }
         }
@@ -337,7 +339,7 @@
         if (schema.patternProperties) {
             props = schema.patternProperties;
             for (p in props) {
-                if (props.hasOwnProperty(p)) {
+                if (props.hasOwnProperty(p) && getType(props[p]) === 'object') {
                     var re = new RegExp(p);
 
                     // Find all object properties that are matching `re`
@@ -349,6 +351,8 @@
                             }
                         }
                     }
+                } else {
+                    console.log('Schema invalid. Property ' + p + ' is not of type object, actual type: ' + getType(props[p]));
                 }
             }
         }
@@ -400,7 +404,6 @@
                 }
             }
         }
-
     }
 
     function validateProperty (object, value, property, schema, options, errors) {

test/revalidator.spec.js

@@ -214,7 +214,8 @@ describe('revalidator', function () {
                 });
 
                 it('should not cast to an integer when the value is a function', function () {
-                    var func = function () {};
+                    var func = function () {
+                    };
                     data = {value: func};
 
                     expect(val.validate(data, schema, {cast: true})).toEqual({
@@ -354,7 +355,8 @@ describe('revalidator', function () {
                 });
 
                 it('should not cast to a float when the value is a function', function () {
-                    var func = function () {};
+                    var func = function () {
+                    };
                     data = {value: func};
 
                     expect(val.validate(data, schema, {cast: true})).toEqual({
@@ -480,7 +482,8 @@ describe('revalidator', function () {
                 });
 
                 it('should not cast to a number when the value is a function', function () {
-                    var func = function () {};
+                    var func = function () {
+                    };
                     data = {value: func};
 
                     expect(val.validate(data, schema, {cast: true})).toEqual({
@@ -626,7 +629,8 @@ describe('revalidator', function () {
                 });
 
                 it('should not cast to a boolean when the value is a function', function () {
-                    var func = function () {};
+                    var func = function () {
+                    };
                     data = {value: func};
 
                     expect(val.validate(data, schema, {cast: true})).toEqual({
@@ -852,5 +856,34 @@ describe('revalidator', function () {
                 message: 'is not defined in schema'
             });
         });
+
+        it('should validate properties when schema itself has properties which are not of type object', function () {
+            schema = {
+                properties: {
+                    a: undefined,
+                    b: {type: 'string'}
+                }
+            };
+            data = {a: 'a', b: 'b', c: 'c'};
+            var res = val.validate(data, schema, {});
+
+            expect(res.valid).toBeTruthy();
+            expect(Object.keys(data).length).toBe(3);
+        });
+
+        it('should validate properties when schema itself has properties which are not of type object and remove properties which have schema with invalid properties', function () {
+            schema = {
+                properties: {
+                    a: undefined,
+                    b: {type: 'string'},
+                    d: []
+                }
+            };
+            data = {a: 'a', b: 'b', c: 'c', d: 'd'};
+            var res = val.validate(data, schema, {unknownProperties: 'delete'});
+
+            expect(res.valid).toBeTruthy();
+            expect(Object.keys(data).length).toBe(1);
+        });
     });
 });