Add max_time keyword argument #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2018 07:50
This addresses #43 The core issue is that with `full_jitter`, `max_tries` is no longer a reliable way to control the total retry time. This adds a similar `max_time` keyword argument which triggers a giveup after a total elapsed amount of time rather than a set number of retries. Further, since full_jitter is actually the default behavior, you probably generally want to use `max_time` rather than `max_tries` so this updates the examples in the README to show that.
Python 2.6's timedelta doesn't have total_seconds() so we implement our own here. It keeps being just easy enough to keep python 2.6 support...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #43
The core issue is that with
full_jitter,max_triesis no longer areliable way to control the total retry time. This adds a similar
max_timekeyword argument which triggers a giveup after a totalelapsed amount of time rather than a set number of retries.
Further, since full_jitter is actually the default behavior, you
probably generally want to use
max_timerather thanmax_triessothis updates the examples in the README to show that.