Custom loggers #64
Merged
Custom loggers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 28, 2018 20:00
This adds a `logger` kwarg to both decorators. This allows the user to specify an alternative logger to use for the backoff and giveup events. This logger can be specified either as a string name or as a Logger object. In addition, the default logging can be disabled entirely by specifying logger=None. In this case, a user could specify their own alterative logging behavior by way of event handlers. This should address multiple issues that have been filed around making logging more customizable, including: litl#37 litl#50 litl#52
bgreen-litl
force-pushed
the
custom-loggers
branch
from
6287d45
to
a469847
Compare
This was referenced Nov 29, 2018
Closed
|
Thanks. I'll try it. |
|
Love it! |
|
.. release pretty please ? |
|
backoff v1.8.0 is now released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
loggerkwarg to both decorators. This allows the userto specify an alternative logger to use for the backoff and giveup
events. This logger can be specified either as a string name or as a
Logger object.
In addition, the default logging can be disabled entirely by
specifying logger=None. In this case, a user could specify their own
alterative logging behavior by way of event handlers.
This should address multiple issues that have been filed around making
logging more customizable, including: