Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diskFill chaos test should use larger than 4K blocks writes to fill the disk #334

Closed
mykaul opened this issue Apr 19, 2021 · 2 comments
Closed

diskFill chaos test should use larger than 4K blocks writes to fill the disk #334

mykaul opened this issue Apr 19, 2021 · 2 comments

Comments

@mykaul
Copy link

mykaul commented Apr 19, 2021

Filling a disk with 4K writes is somewhat slow. It should be done with 1MB or so blocks.
See

litmus-go/chaoslib/litmus/disk-fill/helper/disk-fill.go

Line 165 in c79b9ea

dd := fmt.Sprintf("sudo dd if=/dev/urandom of=/diskfill/%v/diskfill bs=4K count=%v", containerID, strconv.Itoa(sizeTobeFilled/4))

@ksatchit
Copy link
Member

Makes sense. We could make this a tunable with default set to a higher value. Thanks for the suggestion @mykaul

@uditgaurav
Copy link
Member

uditgaurav commented Jun 15, 2021 •
edited
Loading

closing this as the changes are added and are available in 1.13.4 onwards from - #344. Feel free to reopen for any further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mykaul @ksatchit @uditgaurav