Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/subscriber: Interfaces in subscriber #4145

Merged
merged 18 commits into from
Nov 2, 2023

Conversation

SohamRatnaparkhi
Copy link
Contributor

Proposed changes

Interfaces and receiver structs are added to codebase.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

Solves issue - #4144

This PR is related to LFX-Mentorship'23 Term-2 work.

Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Copy link
Contributor

@DarthBenro008 DarthBenro008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a few comments, PTAL

chaoscenter/subscriber/pkg/events/definations.go Outdated Show resolved Hide resolved
chaoscenter/subscriber/pkg/graphql/definations.go Outdated Show resolved Hide resolved
chaoscenter/subscriber/pkg/events/definations.go Outdated Show resolved Hide resolved
chaoscenter/subscriber/pkg/k8s/defination.go Outdated Show resolved Hide resolved
chaoscenter/subscriber/pkg/events/workflow.go Show resolved Hide resolved
chaoscenter/subscriber/subscriber.go Outdated Show resolved Hide resolved
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@SohamRatnaparkhi
Copy link
Contributor Author

@gdsoumya Any updates on this PR?
Thank you!

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Saranya-jena
Copy link
Contributor

Hey @SohamRatnaparkhi subscriber build checks are failing. Could you fix it?

@SohamRatnaparkhi
Copy link
Contributor Author

Yep sure!
Will check them ASAP.

Signed-off-by: SohamRatnaparkhi <soham.ratnaparkhi@gmail.com>
@Saranya-jena Saranya-jena merged commit d4550bd into litmuschaos:master Nov 2, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants