-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant code #4207
Remove redundant code #4207
Conversation
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
chaoscenter/web/src/views/ExperimentDashboardV2/ExperimentDashboardV2Table.tsx
Outdated
Show resolved
Hide resolved
Build checks are failing, can you PTAL @RipulHandoo |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@Saranya-jena I raised a new PR. This time all the checks have passed. |
You have updated this branch right? @RipulHandoo |
@Saranya-jena should I raise PR again. |
Signed-off-by: Saranya Jena <saranya.jena@harness.io>
Hi @RipulHandoo , thanks for the contribution! There are some merge conflicts, can you please update your PR! |
Signed-off-by: Ripul Handoo <107461226+RipulHandoo@users.noreply.github.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@amityt I've solved the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to the litmus repo @RipulHandoo 🚀
Proposed changes
This pull request addresses the issue [ https://github.com//issues/4206 ], which was about removing inefficient code that was causing redundant conditions in the codebase.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
N/A
Special notes for your reviewer:
N/A