Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #4207

Merged

Conversation

RipulHandoo
Copy link
Contributor

Proposed changes

This pull request addresses the issue [ https://github.com//issues/4206 ], which was about removing inefficient code that was causing redundant conditions in the codebase.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

N/A

Special notes for your reviewer:

N/A

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@Saranya-jena
Copy link
Contributor

Build checks are failing, can you PTAL @RipulHandoo

@RipulHandoo
Copy link
Contributor Author

@Saranya-jena I raised a new PR. This time all the checks have passed.

@Saranya-jena
Copy link
Contributor

You have updated this branch right? @RipulHandoo

@RipulHandoo
Copy link
Contributor Author

@Saranya-jena should I raise PR again.
Yes

Signed-off-by: Saranya Jena <saranya.jena@harness.io>
@amityt
Copy link
Contributor

amityt commented Nov 3, 2023

Hi @RipulHandoo , thanks for the contribution! There are some merge conflicts, can you please update your PR!

RipulHandoo and others added 3 commits November 3, 2023 20:53
Signed-off-by: Ripul Handoo <107461226+RipulHandoo@users.noreply.github.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Copy link
Contributor Author

Hi @RipulHandoo , thanks for the contribution! There are some merge conflicts, can you please update your PR!

@amityt I've solved the conflicts.
PTAL!

Copy link
Member

@hrishavjha hrishavjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me 🚀

Copy link
Contributor

@arkajyotiMukherjee arkajyotiMukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the litmus repo @RipulHandoo 🚀

@arkajyotiMukherjee arkajyotiMukherjee merged commit 2c5557a into litmuschaos:master Nov 10, 2023
16 checks passed
@RipulHandoo RipulHandoo deleted the remove-redundant-code branch November 10, 2023 09:12
@RipulHandoo RipulHandoo restored the remove-redundant-code branch November 10, 2023 09:12
@RipulHandoo RipulHandoo deleted the remove-redundant-code branch November 10, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants