-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Litmus Enhancement Proposals directory #4223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
+1 on this, as a reference, I'd suggest taking a look at ArgoCD proposal template, it has been there for some time and seems to work pretty well. |
SarthakJain26
approved these changes
Oct 26, 2023
Signed-off-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Saranya-jena
approved these changes
Oct 27, 2023
Signed-off-by: Saranya Jena <saranya.jena@harness.io>
@gdsoumya Can you PTAL? |
gdsoumya
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I would like to suggest introducing Litmus Enhancement proposals. As our community continues to grow, we can come up with a lot of ideas. I have previously written a proposal for a backstage plugin using Google Docs, but now I propose posting proposals on GitHub. This approach has several advantages over using Google Docs.
People who want to propose new features for Litmus can use the template to submit a new proposal.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Litmus Plugin for Backstage #4023
Special notes for your reviewer: