Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions for chaoscenter unit tests #4244

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

Nageshbansal
Copy link
Contributor

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Fixes #4242

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

@Nageshbansal Nageshbansal marked this pull request as ready for review October 30, 2023 16:48
@Nageshbansal
Copy link
Contributor Author

PTAL @Saranya-jena
Also should i integrate codecov?

@Jonsy13
Copy link
Contributor

Jonsy13 commented Nov 3, 2023

Can you please test this in your fork and add screenshots for the same in PR

Signed-off-by: nagesh bansal <nageshbansal59@gmail.com>
Signed-off-by: nagesh bansal <nageshbansal59@gmail.com>
Signed-off-by: nagesh bansal <nageshbansal59@gmail.com>
@Nageshbansal
Copy link
Contributor Author

@Jonsy13 check are running in the PR itself now ( because of some changes in go.mod). PTAL

@Nageshbansal
Copy link
Contributor Author

here are some screenshots ( build.yml):
image

web-unit-test step:
image

backend-unit-test:
image

backend-unit-test check is failing because of some falling unit tests.

@Jonsy13
Copy link
Contributor

Jonsy13 commented Nov 8, 2023

Merging this PR, Lets fix the tests in a separate PR. cc: @Saranya-jena @SohamRatnaparkhi

@Jonsy13 Jonsy13 merged commit 2acc783 into litmuschaos:master Nov 8, 2023
15 of 16 checks passed
@SohamRatnaparkhi
Copy link
Contributor

Merging this PR, Lets fix the tests in a separate PR. cc: @Saranya-jena @SohamRatnaparkhi

I have created a PR (#4285 ) which might fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UT test checks and coverage for Chaoscenter Auth, GQL and Web
5 participants