-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Test cases for chaosHub views #4249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
S-ayanide
added
kind/unit-test
LFX-MENTORSHIP
Linux Foundation Mentor ship Issue
labels
Nov 15, 2023
S-ayanide
requested changes
Nov 15, 2023
chaoscenter/web/src/views/ChaosFault/__tests__/ChaosFault.test.tsx
Outdated
Show resolved
Hide resolved
chaoscenter/web/src/views/ChaosFault/__tests__/ChaosFault.test.tsx
Outdated
Show resolved
Hide resolved
useStrings: () => ({ getString: (key: any) => key }) | ||
})); | ||
|
||
describe('<ChaosFaultView />', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test is specific to a route, after wrapping the render in test wrapper and default layout, use a before all router push to navigate to that specific route and then carry on the test
beforeAll(() =>
window.history.pushState(
{},
'Chaos Fault',
'/chaos-hubs/6f39cea9-6264-4951-83a8-29976b614289/fault/aws/ecs-instance-stop'
)
);
chaoscenter/web/src/views/ChaosHubMenu/__tests__/ChoasHubMenu.test.tsx
Outdated
Show resolved
Hide resolved
S-ayanide
requested review from
hrishavjha,
arkajyotiMukherjee and
SahilKr24
November 15, 2023 05:30
….tsx Co-authored-by: Sayan Mondal <sayan.mondal@harness.io> Signed-off-by: Magnim BATALE <82499435+Freedisch@users.noreply.github.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
S-ayanide
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added tests cases chaoshub views components
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: