Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Changed 'VALUE' to 'value' for consistency #4253

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

RipulHandoo
Copy link
Contributor

@RipulHandoo RipulHandoo commented Nov 1, 2023

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

This fixs #4176 .
Please review the changes carefully and confirm that the adjustment from 'VALUE' to 'value' is consistent and doesn't introduce any unintended side effects. Thank you for your review!

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a full search and replace for this? It seems like almost all our experiments files in the mkdocs/docs/ have this, would be good to fix them all in one PR.

@RipulHandoo
Copy link
Contributor Author

Can you do a full search and replace for this? It seems like almost all our experiments files in the mkdocs/docs/ have this, would be good to fix them all in one PR.

I search in the mkdocs/docs and there is only one more this

I've update the branch PTAL.

@gdsoumya
Copy link
Member

gdsoumya commented Nov 2, 2023

@RipulHandoo there's surely a lot more
image

@RipulHandoo
Copy link
Contributor Author

@RipulHandoo there's surely a lot more image

I'll make changes right away.

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Copy link
Contributor Author

@gdsoumya
I replaced all the occurrences of "VALUE" to "value".
But there are some other changes as well.
PTAL. if they are alright or not.

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo
Copy link
Contributor Author

LGTM

@gdsoumya
I am signing off the commits.
But still DCO is failing.
Any suggestions

@gdsoumya
Copy link
Member

gdsoumya commented Nov 2, 2023

@RipulHandoo
Copy link
Contributor Author

@RipulHandoo try following the steps here https://github.com/litmuschaos/litmus/pull/4253/checks?check_run_id=18290456286

I tried everything on my end.
Should i close this request and create a new PR for this issue?

@gdsoumya
Copy link
Member

gdsoumya commented Nov 2, 2023

I tried everything on my end. Should i close this request and create a new PR for this issue?

No need, have manually set it to pass.

@ispeakc0de ispeakc0de merged commit 304d32e into litmuschaos:master Nov 2, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants