-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: Changed 'VALUE' to 'value' for consistency #4253
Conversation
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a full search and replace for this? It seems like almost all our experiments files in the mkdocs/docs/
have this, would be good to fix them all in one PR.
I search in the mkdocs/docs and there is only one more this I've update the branch PTAL. |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@RipulHandoo there's surely a lot more |
I'll make changes right away. |
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@gdsoumya |
mkdocs/docs/experiments/categories/aws-ssm/AWS-SSM-experiments-tunables.md
Outdated
Show resolved
Hide resolved
This reverts commit 0567425.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
@gdsoumya |
@RipulHandoo try following the steps here https://github.com/litmuschaos/litmus/pull/4253/checks?check_run_id=18290456286 |
I tried everything on my end. |
No need, have manually set it to pass. |
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer:
This fixs #4176 .
Please review the changes carefully and confirm that the adjustment from 'VALUE' to 'value' is consistent and doesn't introduce any unintended side effects. Thank you for your review!