Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Move the CUSTOM_TLS_CERT from subscriber config to subscribe… #4263

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

RipulHandoo
Copy link
Contributor

…r secret

Proposed changes

It Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret.
fixes #3943

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
RipulHandoo and others added 3 commits November 10, 2023 18:53
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <107461226+RipulHandoo@users.noreply.github.com>
@RipulHandoo
Copy link
Contributor Author

Hey @namkyu1999 , could you review this and help identify why the checks aren't passing?

@namkyu1999
Copy link
Member

Hey @RipulHandoo , You don't have to care about backend-unit-tests check. It's not your problem

@vanshBhatia-A4k9
Copy link
Member

I think these changes will be required for both the ns scope and cluster scope infra manifests right?
As well as appropriate changes in the subscriber where the env variables' values are being set. cc: @Saranya-jena

@Saranya-jena
Copy link
Contributor

@RipulHandoo have you tested the changes?

Copy link
Contributor

@Jonsy13 Jonsy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please make same changes under namespace directory as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret
6 participants