-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: Move the CUSTOM_TLS_CERT from subscriber config to subscribe… #4263
Conversation
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
51d4986
to
94f31d9
Compare
Signed-off-by: Ripul Handoo <ripulhandoo1234@gmail.com>
Signed-off-by: Ripul Handoo <107461226+RipulHandoo@users.noreply.github.com>
Hey @namkyu1999 , could you review this and help identify why the checks aren't passing? |
Hey @RipulHandoo , You don't have to care about |
I think these changes will be required for both the ns scope and cluster scope infra manifests right? |
@RipulHandoo have you tested the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please make same changes under namespace directory as well.
closing due to inactivity |
…r secret
Proposed changes
It Move the CUSTOM_TLS_CERT from subscriber config to subscriber secret.
fixes #3943
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: