Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed main-nav height #4472

Merged

Conversation

milinddethe15
Copy link
Contributor

Closes #4419

Proposed changes

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

After the changes:
https://github.com/litmuschaos/litmus/assets/99114125/347ea8d4-79e6-4a2c-877d-fcbc0c16be20

Signed-off-by: M!l!nd  <99114125+milinddethe15@users.noreply.github.com>
@namkyu1999
Copy link
Member

Hi @milinddethe15 , please check DCO :)

@milinddethe15
Copy link
Contributor Author

i am unsure how to fix DCO.
It shows "Commit sha: 6efb8d9, Author: M!l!nd, Committer: GitHub; Expected "M!l!nd 99114125+milinddethe15@users.noreply.github.com", but got "M!l!nd 99114125+milinddethe15@users.noreply.github.com"."

Copy link
Member

@SahilKr24 SahilKr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good, please attach a short before and after video for quick visualisation.

@SahilKr24
Copy link
Member

SahilKr24 commented Mar 5, 2024

i am unsure how to fix DCO. It shows "Commit sha: 6efb8d9, Author: M!l!nd, Committer: GitHub; Expected "M!l!nd 99114125+milinddethe15@users.noreply.github.com", but got "M!l!nd 99114125+milinddethe15@users.noreply.github.com"."

I think the issue might be because of ! in the name. Unicode values present in gitconfig vs github web might be different. Maybe you can use i and test it out, we will manually set it to pass for this one.

@milinddethe15
Copy link
Contributor Author

before: #4419 (comment)
after: https://github.com/litmuschaos/litmus/assets/99114125/347ea8d4-79e6-4a2c-877d-fcbc0c16be20 (already mentioned in pr comment)

@Saranya-jena Saranya-jena merged commit def75c2 into litmuschaos:master Mar 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dashboard button in side menu in the chaoscenter
6 participants