Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated package #4475

Merged

Conversation

namkyu1999
Copy link
Member

Proposed changes

ioutil package was deprecated since 1.16

this pr replaced ioutil package with the os and io packages.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

namkyu1999 added 3 commits March 1, 2024 18:37
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
@namkyu1999 namkyu1999 added kind/bug go Pull requests that update Go code labels Mar 1, 2024
@namkyu1999 namkyu1999 self-assigned this Mar 1, 2024
namkyu1999 added 2 commits March 1, 2024 21:52
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
chaoscenter/graphql/server/pkg/chaoshub/handler/handler.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/handler/handler.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/handler/handler.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/handler/handler.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/handler/handler.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/service.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/service.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/chaoshub/service.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/gitops/gitops.go Dismissed Show dismissed Hide dismissed
chaoscenter/graphql/server/pkg/gitops/gitops.go Dismissed Show dismissed Hide dismissed
Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr>
@namkyu1999
Copy link
Member Author

Uncontrolled data used in path expression problems existed because we can access file system like ../../etc/passwd. So I solved this issue using path.Clean() function.

@Saranya-jena Saranya-jena merged commit da8ae75 into litmuschaos:master Mar 5, 2024
18 checks passed
amityt added a commit that referenced this pull request Mar 15, 2024
Saranya-jena pushed a commit that referenced this pull request Mar 15, 2024
@namkyu1999 namkyu1999 mentioned this pull request Mar 30, 2024
9 tasks
kartikaysaxena pushed a commit to kartikaysaxena/litmus that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants