Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update package.json to use UICore 4.0.0-beta.1a #4528

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

tan-nhu
Copy link
Contributor

@tan-nhu tan-nhu commented Mar 15, 2024

Proposed changes

While fixing CSS conflict between UICore V3 (from harness-core-ui) and UICore V4, I accidentally unpublished 4.0.0-beta.1. This action is unrecoverable per NPMJS Support team.

This leads to packages that depends on 4.0.0-beta.1 (Limus and Gitness) fail to build.

To fix this issue, a change from 4.0.0-beta.1 to 4.0.0-beta.1a is needed. 4.0.0-beta.1a is exact the same as 4.0.0-beta.1.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

tan-nhu and others added 2 commits March 14, 2024 18:30
While fixing CSS conflict between UICore V3 (from harness-core-ui) and UICore V4, I accidentally unpublished `4.0.0-beta.1`. This action is unrecoverable per NPMJS Support team.

This leads to packages that depends on `4.0.0-beta.1` (Limus and Gitness) fail to build.

To fix this issue, a change from `4.0.0-beta.1` to `4.0.0-beta.1a` is needed. `4.0.0-beta.1a` is exact the same as `4.0.0-beta.1`.

Signed-off-by: Tan Nhu <tan@harness.io>
Copy link
Member

@SahilKr24 SahilKr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Saranya-jena Saranya-jena merged commit 5cad842 into litmuschaos:master Mar 15, 2024
17 checks passed
@tan-nhu tan-nhu deleted the patch-1 branch March 15, 2024 04:11
kartikaysaxena pushed a commit to kartikaysaxena/litmus that referenced this pull request Apr 6, 2024
…haos#4528)

* Update package.json

While fixing CSS conflict between UICore V3 (from harness-core-ui) and UICore V4, I accidentally unpublished `4.0.0-beta.1`. This action is unrecoverable per NPMJS Support team.

This leads to packages that depends on `4.0.0-beta.1` (Limus and Gitness) fail to build.

To fix this issue, a change from `4.0.0-beta.1` to `4.0.0-beta.1a` is needed. `4.0.0-beta.1a` is exact the same as `4.0.0-beta.1`.

Signed-off-by: Tan Nhu <tan@harness.io>

* Update yarn.lock

---------

Signed-off-by: Tan Nhu <tan@harness.io>
Co-authored-by: Tan Nhu <tnhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants