[WIP] : Multiple project owner backend. #4536
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -195,6 +195,30 @@ func GetActiveProjectMembers(service services.ApplicationService) gin.HandlerFun | |
| } | ||
| } | ||
|
|
||
| // GetActiveProjectOwners godoc | ||
| // | ||
| // @Summary Get active project Owners. | ||
| // @Description Return list of active project owners. | ||
| // @Tags ProjectRouter | ||
| // @Param state path string true "State" | ||
| // @Accept json | ||
| // @Produce json | ||
| // @Failure 500 {object} response.ErrServerError | ||
| // @Success 200 {object} response.Response{} | ||
| // @Router /get_project_owners/:project_id/:state [get] | ||
| func GetActiveProjectOwners(service services.ApplicationService) gin.HandlerFunc { | ||
| return func(c *gin.Context) { | ||
| projectID := c.Param("project_id") | ||
| // state := c.Param("state") | ||
| owners, err := service.GetProjectOwners(projectID) | ||
| if err != nil { | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrServerError], presenter.CreateErrorResponse(utils.ErrServerError)) | ||
| return | ||
| } | ||
| c.JSON(http.StatusOK, gin.H{"data": owners}) | ||
| } | ||
| } | ||
|
|
||
| // getInvitation returns the Invitation status | ||
| func getInvitation(service services.ApplicationService, member entities.MemberInput) (entities.Invitation, error) { | ||
| project, err := service.GetProjectByProjectID(member.ProjectID) | ||
|
|
@@ -380,7 +404,7 @@ func SendInvitation(service services.ApplicationService) gin.HandlerFunc { | |
| return | ||
| } | ||
| // Validating member role | ||
| if member.Role == nil || (*member.Role != entities.RoleEditor && *member.Role != entities.RoleViewer && *member.Role != entities.RoleOwner) { | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrInvalidRole], presenter.CreateErrorResponse(utils.ErrInvalidRole)) | ||
| return | ||
| } | ||
|
|
@@ -569,6 +593,20 @@ func LeaveProject(service services.ApplicationService) gin.HandlerFunc { | |
| return | ||
| } | ||
|
|
||
| if member.Role == entities.RoleOwner { | ||
| owners, err := service.GetProjectsOwners(member.ProjectID) | ||
| if err != nil { | ||
| log.Error(err) | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrServerError], presenter.CreateErrorResponse(utils.ErrServerError)) | ||
| return | ||
| } | ||
|
|
||
| if len(owners) == 1 { | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrInvalidRequest], gin.H{"message": "Cannot leave project. There must be at least one owner."}) | ||
| return | ||
| } | ||
| } | ||
|
|
||
| err = validations.RbacValidator(c.MustGet("uid").(string), member.ProjectID, | ||
| validations.MutationRbacRules["leaveProject"], | ||
| string(entities.AcceptedInvitation), | ||
|
|
@@ -726,6 +764,55 @@ func UpdateProjectName(service services.ApplicationService) gin.HandlerFunc { | |
| } | ||
| } | ||
|
|
||
| // UpdateMemberRole godoc | ||
| // | ||
| // @Summary Update member role. | ||
| // @Description Return updated member role. | ||
| // @Tags ProjectRouter | ||
| // @Accept json | ||
| // @Produce json | ||
| // @Failure 400 {object} response.ErrInvalidRequest | ||
| // @Failure 401 {object} response.ErrUnauthorized | ||
| // @Failure 500 {object} response.ErrServerError | ||
| // @Success 200 {object} response.Response{} | ||
| // @Router /update_member_role [post] | ||
| // | ||
| // UpdateMemberRole is used to update a member role in the project | ||
| func UpdateMemberRole(service services.ApplicationService) gin.HandlerFunc { | ||
| return func(c *gin.Context) { | ||
| var member entities.MemberInput | ||
| err := c.BindJSON(&member) | ||
| if err != nil { | ||
| log.Warn(err) | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrInvalidRequest], presenter.CreateErrorResponse(utils.ErrInvalidRequest)) | ||
| return | ||
| } | ||
|
|
||
| err = validations.RbacValidator(c.MustGet("uid").(string), | ||
| member.ProjectID, | ||
| validations.MutationRbacRules["updateMemberRole"], | ||
| string(entities.AcceptedInvitation), | ||
| service) | ||
| if err != nil { | ||
| log.Warn(err) | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrUnauthorized], | ||
| presenter.CreateErrorResponse(utils.ErrUnauthorized)) | ||
| return | ||
| } | ||
|
|
||
| err = service.UpdateMemberRole(member.ProjectID, member.UserID, member.Role) | ||
| if err != nil { | ||
|
There was a problem hiding this comment. I think we should also add one more check for a case: There is only 1 owner and that owner is trying update their role to viewer/editor. In this case there will be no project owner. 🤔 There was a problem hiding this comment. sure I'll do that There was a problem hiding this comment. How about a check to not allow the logged in user to change their own project roles. This will cover all the conditions. Please check on feasibility of this approach and race conditions if any There was a problem hiding this comment. Yes that would be better. cc: @aryan-bhokare |
||
| log.Error(err) | ||
| c.JSON(utils.ErrorStatusCodes[utils.ErrServerError], presenter.CreateErrorResponse(utils.ErrServerError)) | ||
| return | ||
| } | ||
|
|
||
| c.JSON(http.StatusOK, gin.H{ | ||
| "message": "Successfully updated Role", | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // GetOwnerProjects godoc | ||
| // | ||
| // @Summary Get projects owner. | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove if not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure