Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed allErrors flag from PROD env #4614

Merged
merged 3 commits into from
May 15, 2024
Merged

fix: Removed allErrors flag from PROD env #4614

merged 3 commits into from
May 15, 2024

Conversation

hrishavjha
Copy link
Member

@hrishavjha hrishavjha commented May 3, 2024

Proposed changes

AJV package was shipped to PROD env with allErrors flag set to true, this was a risk so added a env check in the statement.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added the necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Hrishav <hrishav.kumar@harness.io>
@hrishavjha hrishavjha self-assigned this May 3, 2024
@neelanjan00 neelanjan00 changed the title fix: Removed allErrors falg from PROD env fix: Removed allErrors flag from PROD env May 9, 2024
@Saranya-jena Saranya-jena merged commit 9b91eb7 into litmuschaos:master May 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants