Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not getting experiment pod logs in the UI and format logs #4732

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

Baalekshan
Copy link
Contributor

@Baalekshan Baalekshan commented Jun 27, 2024

Fixes #4723

Proposed changes

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
This PR aims to fix the issue of not getting experiment pod logs in the UI and better formatting of logs.

image

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

…ution

Signed-off-by: Baalekshan <baalekshan@gmail.com>
@Baalekshan
Copy link
Contributor Author

Creating new PR because #4731 got a bit messier.

@Baalekshan
Copy link
Contributor Author

@Saranya-jena This issue is partially solved (the formatting part has been completed). And for the experiment logs not showing up I am inspecting the CreatePodLog(). When I run a experiment neither experiment pod nor the runner pod logs show up. I only get main logs. Is something wrong with my experiment configuration ?

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Saranya-jena Saranya-jena merged commit 0eceb42 into litmuschaos:master Jul 15, 2024
17 checks passed
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
…chaos#4732)

* fix: Not getting experiment pod logs in the UI during experiment execution

Signed-off-by: Baalekshan <baalekshan@gmail.com>

* made changes

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>

* made changes

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>

---------

Signed-off-by: Baalekshan <baalekshan@gmail.com>
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
…chaos#4732)

* fix: Not getting experiment pod logs in the UI during experiment execution

Signed-off-by: Baalekshan <baalekshan@gmail.com>

* made changes

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>

* made changes

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>

---------

Signed-off-by: Baalekshan <baalekshan@gmail.com>
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788 pushed a commit to sagnik3788/litmus that referenced this pull request Oct 5, 2024
…chaos#4732)

* fix: Not getting experiment pod logs in the UI during experiment execution

Signed-off-by: Baalekshan <baalekshan@gmail.com>

* made changes

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>

* made changes

Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>

---------

Signed-off-by: Baalekshan <baalekshan@gmail.com>
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not getting experiment logs in the UI during experiment execution
6 participants