-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not getting experiment pod logs in the UI and format logs #4732
Conversation
…ution Signed-off-by: Baalekshan <baalekshan@gmail.com>
Creating new PR because #4731 got a bit messier. |
@Saranya-jena This issue is partially solved (the formatting part has been completed). And for the experiment logs not showing up I am inspecting the CreatePodLog(). When I run a experiment neither experiment pod nor the runner pod logs show up. I only get main logs. Is something wrong with my experiment configuration ? |
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
…chaos#4732) * fix: Not getting experiment pod logs in the UI during experiment execution Signed-off-by: Baalekshan <baalekshan@gmail.com> * made changes Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> * made changes Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> --------- Signed-off-by: Baalekshan <baalekshan@gmail.com> Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…chaos#4732) * fix: Not getting experiment pod logs in the UI during experiment execution Signed-off-by: Baalekshan <baalekshan@gmail.com> * made changes Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> * made changes Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> --------- Signed-off-by: Baalekshan <baalekshan@gmail.com> Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…chaos#4732) * fix: Not getting experiment pod logs in the UI during experiment execution Signed-off-by: Baalekshan <baalekshan@gmail.com> * made changes Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> * made changes Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> --------- Signed-off-by: Baalekshan <baalekshan@gmail.com> Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Fixes #4723
Proposed changes
Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue
This PR aims to fix the issue of not getting experiment pod logs in the UI and better formatting of logs.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: