Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for delete/abort when experiment is stuck in Queued state #4856

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Baalekshan
Copy link
Contributor

@Baalekshan Baalekshan commented Aug 31, 2024

Closes #4679

Proposed changes

Running experiments can be stopped now even if stuck in Queued state and then the experiment can be deleted.
When there are running experiments, delete option is disabled
image

When there are no running experiments when stuck in queued state, delete option is enabled
image
image

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x] I have read the CONTRIBUTING doc
  • [x ] I have signed the commit for DCO to be passed.
  • [x ] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Baalekshan and others added 2 commits August 30, 2024 12:50
Signed-off-by: Baalekshan <baalekshan@gmail.com>
Signed-off-by: Baalekshan <69910615+Baalekshan@users.noreply.github.com>
@Saranya-jena Saranya-jena merged commit c8e145c into litmuschaos:master Oct 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for deletion/abort when the Experiment is stuck in Queued state
4 participants