Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probe delete command #207

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Probe delete command #207

merged 2 commits into from
Apr 16, 2024

Conversation

shivam-Purohit
Copy link
Contributor

Add a new feature/command to delete probe.

litmusctl delete probe --project-id="" --probe-id=""

@shivam-Purohit
Copy link
Contributor Author

I am tracking the probes_list. To reduce some time creating the package again. Once that is merged we can move to this

@shivam-Purohit
Copy link
Contributor Author

One thing is
the probe is getting deleted but still returning false in the response.

@shivam-Purohit
Copy link
Contributor Author

One thing is the probe is getting deleted but still returning false in the response.

same thing here, I fixed it with restructuring the response

@shivam-Purohit shivam-Purohit marked this pull request as ready for review April 12, 2024 04:57
Nageshbansal
Nageshbansal suggested changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@Nageshbansal Nageshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a warning before deleting the Probe ( similiar to what we have in chaos-center)

@shivam-Purohit
delete probe command
6242adf 
Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>
@shivam-Purohit
delete probe: add warning
7864be1 
Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>
@SarthakJain26 SarthakJain26 merged commit 025938a into litmuschaos:master Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nageshbansal Nageshbansal Nageshbansal approved these changes

@SarthakJain26 SarthakJain26 SarthakJain26 approved these changes

@Jonsy13 Jonsy13 Awaiting requested review from Jonsy13 Jonsy13 is a code owner

@Saranya-jena Saranya-jena Awaiting requested review from Saranya-jena Saranya-jena is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivam-Purohit @SarthakJain26 @Nageshbansal