Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe delete command #207

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

shivam-Purohit
Copy link
Contributor

Add a new feature/command to delete probe.

litmusctl delete probe --project-id="" --probe-id=""

@shivam-Purohit
Copy link
Contributor Author

I am tracking the probes_list. To reduce some time creating the package again. Once that is merged we can move to this

@shivam-Purohit
Copy link
Contributor Author

One thing is
the probe is getting deleted but still returning false in the response.

@shivam-Purohit
Copy link
Contributor Author

One thing is the probe is getting deleted but still returning false in the response.

same thing here, I fixed it with restructuring the response

Copy link
Collaborator

@Nageshbansal Nageshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a warning before deleting the Probe ( similiar to what we have in chaos-center)

Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>
Signed-off-by: Shivam Purohit <shivampurohit900@gmail.com>
@SarthakJain26 SarthakJain26 merged commit 025938a into litmuschaos:master Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants