Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working under OCaml 5 - but I have working code. #2

Open
stroiman opened this issue Apr 30, 2024 · 1 comment
Open

Not working under OCaml 5 - but I have working code. #2

stroiman opened this issue Apr 30, 2024 · 1 comment

Comments

@stroiman
Copy link

stroiman commented Apr 30, 2024

Hi.

I wanted to use your library for a more lightweight syntax for a unit test framework I'm working on.

But installing it using opam failed miserably, I think due ppx_code is deprecated and incompatible with ocaml 5 (or at least other stuff I have installed)

I managed to replace the ppx_core with ppxlib, fix that part of the code, and also simplify some of the code depending on classes. I haven't used it extensively, but it appears to be working.

I'd not make a PR as such, as I don't know anything about opam packaging, and maybe it should also be dune-ified? I really don't want to spend time researching how to do that just yet (though I'd have to later if I was to publish my own code)

It's currently just in a branch, if you wish to update this.
https://github.com/stroiman/opam-speed/blob/ppx_fun/ppx_fun/ppx_fun.ml

little-arhat added a commit that referenced this issue Apr 30, 2024
Ppx_core is deprecated and incompatible with ocaml 5, ppx_lib should
be used.

Changes to src/ppx_fun courtesy of @stroiman.
@little-arhat
Copy link
Owner

Dunified and update code using your fork, thank you! Also tried dune-release to automate publishing to opam-repo, created a bit of mess in the process %) 0.0.9 version should be published to opam soon ocaml/opam-repository#25780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants