Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display highlighted row number #59

Closed
jungle-boogie opened this issue Jul 8, 2021 · 4 comments
Closed

Display highlighted row number #59

jungle-boogie opened this issue Jul 8, 2021 · 4 comments

Comments

@jungle-boogie
Copy link

Hi,

For the editor, you added in a line and character count. See #23

It would be nice to have the row number displayed when you're clicking around the in the results of your query. I think this could go in between the line number and the elapsed time spot.

thanks!
@jungle-boogie
Copy link
Author

When you double-click a results row, maybe the row number could be included in there as well.

@little-brother
Copy link
Owner

To show row number in the status bar can be ambiguous if there are more than one rows. What problem does this improvement should solve?

The row number in Row view/edit-dialog will be added.

@jungle-boogie
Copy link
Author

You're right, if someone selected non-adjacent records in the results tab, it would be ambiguous.

Could it be hidden in that case and only present if 1 or more adjacent records are selected? Then you could show 1-5 or similar message.

little-brother added a commit that referenced this issue Jul 11, 2021
@little-brother
Up to 1.5.7
06abfff 
* Highlight all occurrences of selected word in editor
* Ctrl + Space allows to select one of column values in Data editor
* Export query result to CSV when row limit is exceeded (issue #58)
* Show a result row number in the statusbar (issue #59)
* Add vsv extension (issue #56)
* Popup menu in terminal output
* Fix minor bugs (issues #57, #61)
@little-brother
Copy link
Owner

The row number was added to statusbar. If more than one line is selected then the first row index show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jungle-boogie @little-brother