Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support :case_insensitive diff-ing option #13

Closed
ronco opened this issue Feb 4, 2016 · 4 comments
Closed

Support :case_insensitive diff-ing option #13

ronco opened this issue Feb 4, 2016 · 4 comments

Comments

@ronco
Copy link
Contributor

ronco commented Feb 4, 2016

Similar to :strip and :numeric_tolerance I think it would be useful to have an option to make string comparisons case insensitive. I'm happy to provide a PR if there would be interest in adding this feature.
@scalp42
Copy link

scalp42 commented Feb 4, 2016

@ronco would be great!

@ronco
Copy link
Contributor Author

ronco commented Feb 5, 2016

Will do. I'll try to put it together this weekend.
On Thu, Feb 4, 2016 at 4:58 PM Anthony Scalisi notifications@github.com
wrote:

@ronco https://github.com/ronco would be great!

—
Reply to this email directly or view it on GitHub
#13 (comment).

@liufengyun
Copy link
Owner

It's definitely welcomed, thx @ronco .

@ronco ronco mentioned this issue Feb 11, 2016
Merged
@ronco
Copy link
Contributor Author

ronco commented Feb 11, 2016

Just submitted PR #14 for this. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronco @liufengyun @scalp42