Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in MFA GEMM #244

Merged
merged 45 commits into from
Jul 24, 2023
Merged

Pull in MFA GEMM #244

merged 45 commits into from
Jul 24, 2023

Conversation

liuliu
Copy link
Owner

@liuliu liuliu commented Jul 24, 2023

No description provided.

philipturner and others added 30 commits June 30, 2023 08:53
@philipturner
Remove .DS_Store
236c315
@philipturner
Initial code for loading MFA
a2f7ccc
@philipturner
Fix error messages
3d9b13f
@philipturner
Attempt to compile C++ code
ca3be9f
@philipturner
Remove unused dependency
810f156
@philipturner
[PATCH] Fix cpp compilation errors.
671e214
@philipturner
Fix error output
7df173e
@philipturner
Refactor the types
fe5d82f
@philipturner
Dispatch C++ bindings
2c4c036
@philipturner
Add hasher
3b97519
@philipturner
Refactor MFA errors
39a0925
@philipturner
Skeleton implementation of 'encode_gemm'
1209765
@philipturner
Calculate threadgroup memory and grid XY
64d84d5
@philipturner
Finish draft of encoding code
ff8c981
@philipturner
MTL::CommandBatch
31eaadb
@philipturner
Detect compatible MFA GEMMs
8b5ce84
@philipturner
Add bias restriction
6bc93fd
@philipturner
Fix up MTL::CommandBatch
5714b29
@philipturner
Fix typo
71d3804
@philipturner
48x48 is the most appropriate default for FP32
0b9788b
@philipturner
It is running
a073382
@liuliu @philipturner
Introduce max stream count when schedule a graph.
435e4db
@liuliu @philipturner
Avoid stack allocation if it is too large.
fd4e127
@liuliu @philipturner
Don't allocate gradients if it doesn't compute.
7d921de
@liuliu @philipturner
No gradients are allocated if these are not trainable.
0bf52d3
@philipturner
Fix up the map
5f15df3
@philipturner
Document the block sizes
a5af13d
@philipturner
Block size selection heuristic
a48c050
@philipturner
Preparation for batching
d3641a5
@philipturner
Add code for encoding the matrix offsets in a batch
e2a51e1
philipturner
philipturner suggested changes Jul 24, 2023
View reviewed changes
lib/nnc/mfa/ccv_nnc_mfa_gemm.cpp Outdated Show resolved Hide resolved
@liuliu @philipturner
Update lib/nnc/mfa/ccv_nnc_mfa_gemm.cpp
33f1bc4 
Co-authored-by: Philip Turner <philipturner.AR@gmail.com>
@liuliu liuliu merged commit bbd3810 into unstable Jul 24, 2023
@liuliu liuliu deleted the liu/mfa branch July 24, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipturner philipturner philipturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuliu @philipturner