Livebook cell won't give up the focus to firenvim

[drselump14]

Environment

• Elixir & Erlang/OTP versions (elixir --version): 1.14.2 otp 25
• Operating system: MacOS Ventura
• How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): livebook CLI/Desktop
• Livebook version (use git rev-parse HEAD if running with mix): 0.8.1
• Browsers that reproduce this bug (the more the merrier): Firefox, Chrome
• Include what is logged in the browser console: nothing
• Include what is logged to the server console: nothing

Current behavior

Launch firenvim on the cell, but Firenvim doesn't get the focus, so then every event is still sent to livebook cell.
I need to click outside the frame and click the frame again to get the focus.

Expected behavior

Launch firenvim on the cell, the focus would be on firenvim and every event is sent to firenvim instance.

[josevalim]

Thank you for the report. We will appreciate if someone can look into this issue and provide a fix. We are glad firenvim is an option but we have little bandwidth to prioritize this issue.

[drselump14]

Hi, thanks a lot for the reply. I understand the situation. Is there any idea which livebook code I can start to look at to fix the issue?

[josevalim]

@jonatanklosko would be the person to provide a pointer. But, just in case, did you check that the issue also does not happen in regular Monaco?

[jonatanklosko]

In insert mode we always make sure the Monaco editor is focused:

livebook/assets/js/hooks/cell.js

Lines 190 to 196 in 605498a

	liveEditor.onBlur(() => {
	// Prevent from blurring unless the state changes. For example
	// when we move cell using buttons the editor should keep focus
	if (this.isFocused && this.insertMode) {
	this.currentEditor().focus();
	}
	});

so the focus goes to the original editor.

[josevalim]

I will go ahead and close this. If someone wants to send a PR though, it is very welcome. We wouldn't mind special casing the focus logic to consider firenvim classes and act accordingly. It should be a small change in theory. :) Thanks!