place efiboot.img and macboot.img in /isolinux

[sobjerke]

#188 create efi image files under /isolinux, not /images

[Conan-Kudo]

I think @FGrose changed this to match Lorax, it might be worth him looking at this...

[sobjerke]

Seems like the change happened in this commit back in 2019:
e4c96c2

However, when mkefiboot tries to create the image, the directory /images does not exist, and efiboot.img never gets created, resulting in iso image that is not bootable at all.

I can see two options here

1. make sure /images is created before mkefiboot is run (and update any other references to the path)
2. revert the change and put the files in /isolinux

[Conan-Kudo]

@sobjerke I would prefer a change to make it so that /images existed. Aligning with Lorax makes things less painful down the road.

[sobjerke]

@Conan-Kudo and @FGrose: Does this look like the correct place to create /images?

diff --git a/imgcreate/live.py b/imgcreate/live.py
index 673c54d..0eb6fdb 100644
--- a/imgcreate/live.py
+++ b/imgcreate/live.py
@@ -237,6 +237,7 @@ class LiveImageCreatorBase(LoopImageCreator):
             return

         # XXX-BCL: does this need --label?
+        makedirs(isodir + "/images")
         subprocess.call(["mkefiboot", isodir + "/EFI/BOOT",
                          isodir + "/images/efiboot.img"])

With this change and a modified version of #190 to reflect the changed path of efiboot.img, I am now able to create a live image of CentOS 8 that is bootable both via bios and efi.

If you agree, I will replace #189 with a new PR.

[mikhailnov]

This is also needed for ROSA

[Conan-Kudo]

Let's take this for now and fix it later.