add getActiveAudioOutputDevice to room API #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8524fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
davideberlein
force-pushed
the
add-getActiveAudioOutputDevice-method-to-room
branch
from
0e177e6
to
d8524fe
Compare
lukasIO
approved these changes
Nov 1, 2022
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* add getActiveAudioOutputDevice to room API * add changeset * run prettier * return an empty string if no audiooutput device was set
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* add getActiveAudioOutputDevice to room API * add changeset * run prettier * return an empty string if no audiooutput device was set
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 9, 2022
* add getActiveAudioOutputDevice to room API * add changeset * run prettier * return an empty string if no audiooutput device was set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #497
This is a very trivial implementation. I was working on some more advanced version trying to figure out the default device if no
deviceIdis currently set however I'm not sure this really adds any value.Then again, as far as I can see the
optionsare public so one wouldn't really need this method.If we decide to remove the method I'd change this PR to document the ways to access the current devices on the
switchActiveDevicemethod so people find this faster.