Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for server injected frame trailer being passed down #812

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jul 27, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

🦋 Changeset detected

Latest commit: db93328

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 75.43 KB (+0.12% 🔺)
dist/livekit-client.umd.js 80.82 KB (+0.11% 🔺)

@lukasIO lukasIO marked this pull request as ready for review July 27, 2023 11:24
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments.

src/e2ee/worker/FrameCryptor.ts Outdated Show resolved Hide resolved
src/e2ee/worker/FrameCryptor.ts Outdated Show resolved Hide resolved
src/e2ee/worker/FrameCryptor.ts Outdated Show resolved Hide resolved
* Drop frames if more than MAX_SIF_COUNT consecutive SIFs come in

* log warning

* extract sif guard logic into class
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lukasIO lukasIO merged commit 6acc705 into main Aug 8, 2023
2 checks passed
@lukasIO lukasIO deleted the lukas/e2ee-injected-trailer branch August 8, 2023 08:29
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants