Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vp9 svc encode failed for screenshare #882

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

cnderrauber
Copy link
Contributor

VP9 SVC for screenshare has problem to encode with error Failed to initialize the encoder associated with codec type: VP9 (2), use L1T3 mode for screenshare video track to fix it.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 2d7230b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 76.56 KB (+0.05% 🔺)
dist/livekit-client.umd.js 82.15 KB (+0.03% 🔺)

@davidzhao
Copy link
Member

Does AV1 have the same issue?

@davidzhao davidzhao merged commit 4e4e80a into main Sep 28, 2023
3 checks passed
@davidzhao davidzhao deleted the vp9svc_screenshare branch September 28, 2023 17:21
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
@cnderrauber
Copy link
Contributor Author

@davidzhao AV1 works well for screen share with L3T3 mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants