Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for updating name and metadata of LocalParticipant #201

Merged
merged 2 commits into from
May 16, 2023

Conversation

hiroshihorie
Copy link
Member

livekit/client-sdk-js#599

Should we have a way to fail if CanUpdateOwnMetadata permission doesn't exist ?

@lukasIO
Copy link
Contributor

lukasIO commented Apr 11, 2023

I think something like that makes sense, @davidliu proposed to wait for a local participant metadata update event to come in before returning.
using the permissions locally has the disadvantage that the permissions might have just been updated and only the server is aware of them right now.
using the metadata update as an indicator that it resolved properly has the downside that this update might also be coming from a server sdk and might be unrelated (we could get around that by checking the contents of the update)

@hiroshihorie
Copy link
Member Author

That sounds good 👍

@hiroshihorie
Copy link
Member Author

@lukasIO Can I merge this ?

@lukasIO
Copy link
Contributor

lukasIO commented May 16, 2023

yeah, let's iterate on how to acknowledge it later on. As long as the function is async we can add additional logic for that later!

@hiroshihorie hiroshihorie merged commit f8f1eb9 into main May 16, 2023
@hiroshihorie hiroshihorie deleted the update-local-name-and-metadata branch May 16, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants