More theming options #48
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: cd11921 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -1,6 +1,6 @@ | |||
| import { Participant } from 'livekit-client'; | |||
| import { createConnectionQualityObserver } from '../observables/participant'; | |||
| import { ClassNames } from '@livekit/components-styles/dist/types/styles.css'; | |||
| import { ClassNames } from '@livekit/components-styles/dist/types/general/styles.css'; | |||
|
|
|||
| export function setupConnectionQualityIndicator(participant: Participant) { | |||
| const className: ClassNames = 'lk-connection-quality'; | |||
There was a problem hiding this comment.
Here we could use the lkClassName('connection-quality') function to return the prefixed version of the class name.
This way you also don't have to import the ClassNames in all the files.
| $t-danger: fn.css-var-with-sass-fallback('danger', $danger); | ||
| $t-light: fn.css-var-with-sass-fallback('light', $light); | ||
| $t-dark: fn.css-var-with-sass-fallback('dark', $dark); | ||
| // Custom Property Definitions |
There was a problem hiding this comment.
We should decide whether to use the name custom properties or CSS variables. I have no problem with custom properties and cp. But maybe the Sass function "fn.to-css-var" should be called "fn.to-cp" then? 🤔
| @@ -2,6 +2,7 @@ | |||
| @use '../variables' as v; | |||
|
|
|||
| .disconnect-button { | |||
| @extend .button; | |||
There was a problem hiding this comment.
Just out of curiosity: When should we use @extend, @include and when is it better to use a @mixin? Maybe we can capture the reasons for this decision in the README, so we can look them up later.
No description provided.