Added Content-Resolution to prepare & transcode #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
approved these changes
May 13, 2022
Comment on lines
+165
to
+170
| for _, track := range tctx.InputAsset.AssetSpec.VideoSpec.Tracks { | ||
| if track.Type == "video" { | ||
| contentResolution = fmt.Sprintf("%dx%d", track.Width, track.Height) | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: We should probably create a litle helper/utility to grab the video track from an asset spec (or maybe receiving a trackType string and returning the first track with that). We have this exact same loop repeated in a couple of places now.
There was a problem hiding this comment.
Gonna do this in another pr
gioelecerati
force-pushed
the
gio/prepare/contentresolution
branch
from
83f253a
to
b02bd95
Compare
figintern
reviewed
May 26, 2022
| @@ -4,7 +4,7 @@ go 1.16 | |||
|
|
|||
| require ( | |||
| github.com/golang/glog v1.0.0 | |||
| github.com/livepeer/go-api-client v0.1.2 | |||
| github.com/livepeer/go-api-client v0.1.3-0.20220513154150-a37f7c0b5586 | |||
There was a problem hiding this comment.
v0.1.3
https://github.com/livepeer/go-api-client/releases/tag/v0.1.3
go get github.com/livepeer/go-api-client@v0.1.3
go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Depends on livepeer/go-api-client#6
What does it do?
Retrieve the source asset resolution and provide it to PushSegment, to be used as a Content-Resolution header and display the source resolution correctly.