task/progress: Add Progress Tracking to Transcode and Prepare #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figintern
force-pushed
the
tq/task-progress
branch
from
e9c0884
to
3ab5944
Compare
hjpotter92
reviewed
Jun 6, 2022
victorges
approved these changes
Jun 7, 2022
figintern
force-pushed
the
tq/task-progress
branch
from
3ab5944
to
145b5aa
Compare
figintern
force-pushed
the
tq/task-progress
branch
3 times, most recently
from
1d5e9f3
to
46f4379
Compare
figintern
force-pushed
the
tq/task-progress
branch
from
46f4379
to
06d447c
Compare
figintern
force-pushed
the
tq/task-progress
branch
from
b20c221
to
0e22e22
Compare
figintern
force-pushed
the
tq/task-progress
branch
from
0b4f75c
to
58393c6
Compare
victorges
reviewed
Jun 17, 2022
victorges
requested changes
Jun 17, 2022
task/import.go
Outdated
| glog.Errorf("error preparing imported file assetId=%s err=%q", tctx.OutputAsset.ID, err) | ||
| // TODO: make these fatal once we're confident about prepare reliability | ||
| return "", nil | ||
| glog.Fatalf("error preparing imported file assetId=%s err=%q", tctx.OutputAsset.ID, err) |
There was a problem hiding this comment.
These should not be fatal to the whole process. They should only be fatal for the task.
So instead of a fatal log here you should just return the error instead of ignoring it. Otherwise the whole process will crash and every other unrelated task will fail with it as well.
victorges
reviewed
Jun 17, 2022
victorges
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26 #40
Refactor
ReportProgresslogic to specify progress sub-window between 0 and 100 percent. Percentage progress of getCount/size is applied only to the sub-window of overall progress.Track progress for
transcodeandprocesstasks using size of segments pushed relative to overall size of the file.transcode/processandimport/processtasks are 50-50 split between the progress bar, this is easily adjustable.Makes Prepare sub-task failures fatal
Also fixes bug in
probe.gowhich causes error whenvideo pixel formatcould not be probed from file and is empty