task: Update go-api-client and stream-tester with fixes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error handlign on segmenter
If the loop finishes because ctx was cancelled, we'll have no indication about the cancellation. Need to check that explicitly. Also notice that even if the segmenter sent the error on the output channel, it would not be sufficient. That because if the ctx is cancelled, it might end up never sending the error anyway so we'd still need to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates both stream-tester and go-api-client with the following fixes:
Upon fixing the usage of the libs, I also figured out that cancellation was not being
handled properly in the transcode and prepare tasks. Without livepeer/stream-tester#164
it actually wouldn't be fixable, since the segmenter didn't handle cancellation, but
now it does!
So this also finally fixes NOT #19 !!Actually figured out that this only fixes cancellation on transcode/prepare. There may
still be something wrong with the import logic :(